Skip to content

Commit

Permalink
gdb: Fix ia64 defining TRAP_HWBKPT before including gdb_wait.h
Browse files Browse the repository at this point in the history
On ia64, gdb_wait.h eventually includes siginfo-consts-arch.h, which
contains an enum with TRAP_HWBKPT, along with a #define. Thus we cannot
define TRAP_HWBKPT to 4 beforehand, and so gdb_wait.h must be included
earlier; include it from linux-ptrace.h so it can never come afterwards.

gdb/ChangeLog:

	* nat/linux-ptrace.c: Remove unnecessary reinclusion of
	gdb_ptrace.h, and move including gdb_wait.h ...
	* nat/linux-ptrace.h: ... to here.
  • Loading branch information
jrtc27 authored and palves committed Jan 19, 2018
1 parent bc09b0c commit 5a6c329
Show file tree
Hide file tree
Showing 3 changed files with 7 additions and 2 deletions.
6 changes: 6 additions & 0 deletions gdb/ChangeLog
@@ -1,3 +1,9 @@
2018-01-19 James Clarke <jrtc27@jrtc27.com>

* nat/linux-ptrace.c: Remove unnecessary reinclusion of
gdb_ptrace.h, and move including gdb_wait.h ...
* nat/linux-ptrace.h: ... to here.

2018-01-19 Simon Marchi <simon.marchi@ericsson.com>

* inf-ptrace.c (inf_ptrace_detach): Adjust call to
Expand Down
2 changes: 0 additions & 2 deletions gdb/nat/linux-ptrace.c
Expand Up @@ -21,8 +21,6 @@
#include "linux-procfs.h"
#include "linux-waitpid.h"
#include "buffer.h"
#include "gdb_wait.h"
#include "gdb_ptrace.h"
#ifdef HAVE_SYS_PROCFS_H
#include <sys/procfs.h>
#endif
Expand Down
1 change: 1 addition & 0 deletions gdb/nat/linux-ptrace.h
Expand Up @@ -21,6 +21,7 @@
struct buffer;

#include "nat/gdb_ptrace.h"
#include "gdb_wait.h"

#ifdef __UCLIBC__
#if !(defined(__UCLIBC_HAS_MMU__) || defined(__ARCH_HAS_MMU__))
Expand Down

0 comments on commit 5a6c329

Please sign in to comment.