Skip to content

Commit

Permalink
RISC-V: Fix minor issues with FP csr instructions.
Browse files Browse the repository at this point in the history
	Mel Chen <mel.chen@sifive.com>
	gas/
	* testsuite/gas/riscv/alias-csr.s: Add testcase for CSR-access
	alias instructions.
	* testsuite/gas/riscv/no-aliases-csr.d: Run testcase alias-csr.s with
	-Mno-aliases.
	* testsuite/gas/riscv/alias-csr.d: Run testcase alias-csr.s.
	* testsuite/gas/riscv/priv-reg.d: Update.
	opcodes/
	* riscv-opc.c (riscv_opcodes): Set frsr, fssr, frcsr, fscsr, frrm,
	fsrm, fsrmi, frflags, fsflags, fsflagsi to alias instructions.
	* riscv-opc.c (riscv_opcodes): Adjust order of frsr, frcsr, fssr,
	fscsr.
  • Loading branch information
Jim Wilson committed Jul 30, 2019
1 parent aa3b653 commit c0d6f62
Show file tree
Hide file tree
Showing 7 changed files with 95 additions and 17 deletions.
10 changes: 10 additions & 0 deletions gas/ChangeLog
Original file line number Diff line number Diff line change
@@ -1,3 +1,13 @@
2019-07-30 Mel Chen <mel.chen@sifive.com>

* testsuite/gas/riscv/alias-csr.s: Add testcase for CSR-access
alias instructions.
* testsuite/gas/riscv/no-aliases-csr.d: Run testcase alias-csr.s with
-Mno-aliases.

* testsuite/gas/riscv/alias-csr.d: Run testcase alias-csr.s.
* testsuite/gas/riscv/priv-reg.d: Update.

2019-07-24 Nick Clifton <nickc@redhat.com>

* po/sv.po: Updated Swedish translation.
Expand Down
23 changes: 23 additions & 0 deletions gas/testsuite/gas/riscv/alias-csr.d
Original file line number Diff line number Diff line change
@@ -0,0 +1,23 @@
#source: alias-csr.s
#as: -march=rv64if
#objdump: -dr

.*:[ ]+file format .*


Disassembly of section .text:

0+000 <alias_csr>:
[ ]+0:[ ]+003022f3[ ]+frcsr[ ]+t0
[ ]+4:[ ]+003392f3[ ]+fscsr[ ]+t0,t2
[ ]+8:[ ]+00339073[ ]+fscsr[ ]+t2
[ ]+c:[ ]+002022f3[ ]+frrm[ ]+t0
[ ]+10:[ ]+002312f3[ ]+fsrm[ ]+t0,t1
[ ]+14:[ ]+00231073[ ]+fsrm[ ]+t1
[ ]+18:[ ]+002fd2f3[ ]+fsrmi[ ]+t0,31
[ ]+1c:[ ]+002fd073[ ]+fsrmi[ ]+zero,31
[ ]+20:[ ]+001022f3[ ]+frflags[ ]+t0
[ ]+24:[ ]+001312f3[ ]+fsflags[ ]+t0,t1
[ ]+28:[ ]+00131073[ ]+fsflags[ ]+t1
[ ]+2c:[ ]+001fd2f3[ ]+fsflagsi[ ]+t0,31
[ ]+30:[ ]+001fd073[ ]+fsflagsi[ ]+zero,31
14 changes: 14 additions & 0 deletions gas/testsuite/gas/riscv/alias-csr.s
Original file line number Diff line number Diff line change
@@ -0,0 +1,14 @@
alias_csr:
frcsr t0
fscsr t0, t2
fscsr t2
frrm t0
fsrm t0, t1
fsrm t1
fsrmi t0, 31
fsrmi 31
frflags t0
fsflags t0, t1
fsflags t1
fsflagsi t0, 31
fsflagsi 31
23 changes: 23 additions & 0 deletions gas/testsuite/gas/riscv/no-aliases-csr.d
Original file line number Diff line number Diff line change
@@ -0,0 +1,23 @@
#source: alias-csr.s
#as: -march=rv64if
#objdump: -dr -Mno-aliases

.*:[ ]+file format .*


Disassembly of section .text:

0+000 <alias_csr>:
[ ]+0:[ ]+003022f3[ ]+csrrs[ ]+t0,fcsr,zero
[ ]+4:[ ]+003392f3[ ]+csrrw[ ]+t0,fcsr,t2
[ ]+8:[ ]+00339073[ ]+csrrw[ ]+zero,fcsr,t2
[ ]+c:[ ]+002022f3[ ]+csrrs[ ]+t0,frm,zero
[ ]+10:[ ]+002312f3[ ]+csrrw[ ]+t0,frm,t1
[ ]+14:[ ]+00231073[ ]+csrrw[ ]+zero,frm,t1
[ ]+18:[ ]+002fd2f3[ ]+csrrwi[ ]+t0,frm,31
[ ]+1c:[ ]+002fd073[ ]+csrrwi[ ]+zero,frm,31
[ ]+20:[ ]+001022f3[ ]+csrrs[ ]+t0,fflags,zero
[ ]+24:[ ]+001312f3[ ]+csrrw[ ]+t0,fflags,t1
[ ]+28:[ ]+00131073[ ]+csrrw[ ]+zero,fflags,t1
[ ]+2c:[ ]+001fd2f3[ ]+csrrwi[ ]+t0,fflags,31
[ ]+30:[ ]+001fd073[ ]+csrrwi[ ]+zero,fflags,31
2 changes: 1 addition & 1 deletion gas/testsuite/gas/riscv/priv-reg.d
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,7 @@ Disassembly of section .text:
[ ]+1c:[ ]+04402573[ ]+csrr[ ]+a0,uip
[ ]+20:[ ]+00102573[ ]+frflags[ ]+a0
[ ]+24:[ ]+00202573[ ]+frrm[ ]+a0
[ ]+28:[ ]+00302573[ ]+frsr[ ]+a0
[ ]+28:[ ]+00302573[ ]+frcsr[ ]+a0
[ ]+2c:[ ]+c0002573[ ]+rdcycle[ ]+a0
[ ]+30:[ ]+c0102573[ ]+rdtime[ ]+a0
[ ]+34:[ ]+c0202573[ ]+rdinstret[ ]+a0
Expand Down
8 changes: 8 additions & 0 deletions opcodes/ChangeLog
Original file line number Diff line number Diff line change
@@ -1,3 +1,11 @@
2019-07-30 Mel Chen <mel.chen@sifive.com>

* riscv-opc.c (riscv_opcodes): Set frsr, fssr, frcsr, fscsr, frrm,
fsrm, fsrmi, frflags, fsflags, fsflagsi to alias instructions.

* riscv-opc.c (riscv_opcodes): Adjust order of frsr, frcsr, fssr,
fscsr.

2019-07-24 Claudiu Zissulescu <claziss@synopsys.com>

* arc-dis.c (skip_this_opcode): Check also for 0x07 major opcodes,
Expand Down
32 changes: 16 additions & 16 deletions opcodes/riscv-opc.c
Original file line number Diff line number Diff line change
Expand Up @@ -496,22 +496,22 @@ const struct riscv_opcode riscv_opcodes[] =
{"remuw", 64, {"M", 0}, "d,s,t", MATCH_REMUW, MASK_REMUW, match_opcode, 0 },

/* Single-precision floating-point instruction subset */
{"frsr", 0, {"F", 0}, "d", MATCH_FRCSR, MASK_FRCSR, match_opcode, 0 },
{"fssr", 0, {"F", 0}, "s", MATCH_FSCSR, MASK_FSCSR | MASK_RD, match_opcode, 0 },
{"fssr", 0, {"F", 0}, "d,s", MATCH_FSCSR, MASK_FSCSR, match_opcode, 0 },
{"frcsr", 0, {"F", 0}, "d", MATCH_FRCSR, MASK_FRCSR, match_opcode, 0 },
{"fscsr", 0, {"F", 0}, "s", MATCH_FSCSR, MASK_FSCSR | MASK_RD, match_opcode, 0 },
{"fscsr", 0, {"F", 0}, "d,s", MATCH_FSCSR, MASK_FSCSR, match_opcode, 0 },
{"frrm", 0, {"F", 0}, "d", MATCH_FRRM, MASK_FRRM, match_opcode, 0 },
{"fsrm", 0, {"F", 0}, "s", MATCH_FSRM, MASK_FSRM | MASK_RD, match_opcode, 0 },
{"fsrm", 0, {"F", 0}, "d,s", MATCH_FSRM, MASK_FSRM, match_opcode, 0 },
{"fsrmi", 0, {"F", 0}, "d,Z", MATCH_FSRMI, MASK_FSRMI, match_opcode, 0 },
{"fsrmi", 0, {"F", 0}, "Z", MATCH_FSRMI, MASK_FSRMI | MASK_RD, match_opcode, 0 },
{"frflags", 0, {"F", 0}, "d", MATCH_FRFLAGS, MASK_FRFLAGS, match_opcode, 0 },
{"fsflags", 0, {"F", 0}, "s", MATCH_FSFLAGS, MASK_FSFLAGS | MASK_RD, match_opcode, 0 },
{"fsflags", 0, {"F", 0}, "d,s", MATCH_FSFLAGS, MASK_FSFLAGS, match_opcode, 0 },
{"fsflagsi", 0, {"F", 0}, "d,Z", MATCH_FSFLAGSI, MASK_FSFLAGSI, match_opcode, 0 },
{"fsflagsi", 0, {"F", 0}, "Z", MATCH_FSFLAGSI, MASK_FSFLAGSI | MASK_RD, match_opcode, 0 },
{"frcsr", 0, {"F", 0}, "d", MATCH_FRCSR, MASK_FRCSR, match_opcode, INSN_ALIAS },
{"frsr", 0, {"F", 0}, "d", MATCH_FRCSR, MASK_FRCSR, match_opcode, INSN_ALIAS },
{"fscsr", 0, {"F", 0}, "s", MATCH_FSCSR, MASK_FSCSR | MASK_RD, match_opcode, INSN_ALIAS },
{"fscsr", 0, {"F", 0}, "d,s", MATCH_FSCSR, MASK_FSCSR, match_opcode, INSN_ALIAS },
{"fssr", 0, {"F", 0}, "s", MATCH_FSCSR, MASK_FSCSR | MASK_RD, match_opcode, INSN_ALIAS },
{"fssr", 0, {"F", 0}, "d,s", MATCH_FSCSR, MASK_FSCSR, match_opcode, INSN_ALIAS },
{"frrm", 0, {"F", 0}, "d", MATCH_FRRM, MASK_FRRM, match_opcode, INSN_ALIAS },
{"fsrm", 0, {"F", 0}, "s", MATCH_FSRM, MASK_FSRM | MASK_RD, match_opcode, INSN_ALIAS },
{"fsrm", 0, {"F", 0}, "d,s", MATCH_FSRM, MASK_FSRM, match_opcode, INSN_ALIAS },
{"fsrmi", 0, {"F", 0}, "d,Z", MATCH_FSRMI, MASK_FSRMI, match_opcode, INSN_ALIAS },
{"fsrmi", 0, {"F", 0}, "Z", MATCH_FSRMI, MASK_FSRMI | MASK_RD, match_opcode, INSN_ALIAS },
{"frflags", 0, {"F", 0}, "d", MATCH_FRFLAGS, MASK_FRFLAGS, match_opcode, INSN_ALIAS },
{"fsflags", 0, {"F", 0}, "s", MATCH_FSFLAGS, MASK_FSFLAGS | MASK_RD, match_opcode, INSN_ALIAS },
{"fsflags", 0, {"F", 0}, "d,s", MATCH_FSFLAGS, MASK_FSFLAGS, match_opcode, INSN_ALIAS },
{"fsflagsi", 0, {"F", 0}, "d,Z", MATCH_FSFLAGSI, MASK_FSFLAGSI, match_opcode, INSN_ALIAS },
{"fsflagsi", 0, {"F", 0}, "Z", MATCH_FSFLAGSI, MASK_FSFLAGSI | MASK_RD, match_opcode, INSN_ALIAS },
{"flw", 32, {"F", "C", 0}, "D,Cm(Cc)", MATCH_C_FLWSP, MASK_C_FLWSP, match_opcode, INSN_ALIAS|INSN_DREF|INSN_4_BYTE },
{"flw", 32, {"F", "C", 0}, "CD,Ck(Cs)", MATCH_C_FLW, MASK_C_FLW, match_opcode, INSN_ALIAS|INSN_DREF|INSN_4_BYTE },
{"flw", 0, {"F", 0}, "D,o(s)", MATCH_FLW, MASK_FLW, match_opcode, INSN_DREF|INSN_4_BYTE },
Expand Down

0 comments on commit c0d6f62

Please sign in to comment.