Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve output formatting for mismatched versions #185

Merged
merged 11 commits into from
Sep 5, 2021

Conversation

ddzz
Copy link
Collaborator

@ddzz ddzz commented Sep 5, 2021

Before:

Screen Shot 2021-09-05 at 2 35 20 PM

After:

Screen Shot 2021-09-05 at 2 55 24 PM

lib/output.ts Outdated Show resolved Hide resolved
lib/output.ts Outdated Show resolved Hide resolved
lib/output.ts Outdated Show resolved Hide resolved
lib/output.ts Outdated Show resolved Hide resolved
@bmish bmish changed the title Improve output for mismatched versions Use multiple lines for mismatched version output Sep 5, 2021
@bmish bmish added the enhancement New feature or request label Sep 5, 2021
@ddzz ddzz requested a review from bmish September 5, 2021 19:49
package.json Outdated Show resolved Hide resolved
@bmish bmish changed the title Use multiple lines for mismatched version output Improve output formatting for mismatched versions Sep 5, 2021
@bmish
Copy link
Owner

bmish commented Sep 5, 2021

README.md example needs to be updated with the new format.

@ddzz
Copy link
Collaborator Author

ddzz commented Sep 5, 2021

README.md example needs to be updated with the new format.

Fixed

@bmish
Copy link
Owner

bmish commented Sep 5, 2021

I'm guessing the tests are failing because the github actions terminal has color output turned off: https://github.com/chalk/chalk#supportscolor

@ddzz
Copy link
Collaborator Author

ddzz commented Sep 5, 2021

I'm guessing the tests are failing because the github actions terminal has color output turned off: https://github.com/chalk/chalk#supportscolor

That's what I suspected. Fixed it by adding the --colors flag to the test script.

@ddzz ddzz requested a review from bmish September 5, 2021 20:59
Copy link
Owner

@bmish bmish left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work!

@bmish bmish merged commit c2d94c2 into bmish:master Sep 5, 2021
@ddzz ddzz deleted the improve-output branch September 6, 2021 00:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants