Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Display dependency versions in descending instead of ascending order #189

Merged
merged 2 commits into from
Sep 8, 2021

Conversation

ddzz
Copy link
Collaborator

@ddzz ddzz commented Sep 6, 2021

Before:
Screen Shot 2021-09-08 at 6 46 44 PM

After:
Screen Shot 2021-09-08 at 6 47 04 PM

@bmish
Copy link
Owner

bmish commented Sep 6, 2021

I need some convincing (maybe an example) about why descending order would be more intuitive than ascending order here.

@ddzz
Copy link
Collaborator Author

ddzz commented Sep 6, 2021

I need some convincing (maybe an example) about why descending order would be more intuitive than ascending order here.

In many cases (probably most cases) the most recent version will be used to resolve an inconsistency, so it makes sense to show the most relevant version first.

@bmish
Copy link
Owner

bmish commented Sep 7, 2021

I'll consider this in the coming days. The README would need to be updated to go along with this if accepted.

@bmish
Copy link
Owner

bmish commented Sep 8, 2021

@ddzz I'm ready to accept this, please rebase and update tests/docs, and show an example.

@bmish bmish added the enhancement New feature or request label Sep 8, 2021
@bmish bmish changed the title Reverse package version output order Display package versions in descending instead of ascending order Sep 8, 2021
@ddzz
Copy link
Collaborator Author

ddzz commented Sep 8, 2021

@bmish PR has been updated.

Copy link
Owner

@bmish bmish left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@bmish bmish merged commit 4febe15 into bmish:master Sep 8, 2021
@ddzz ddzz deleted the reverse-version-order branch September 8, 2021 23:53
@bmish bmish changed the title Display package versions in descending instead of ascending order Display dependency versions in descending instead of ascending order Sep 9, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants