Bold maximum usage count for each mismatched dependency #206
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bmish
force-pushed
the
max-usage-count
branch
from
40eec86
to
51f9f7a
Compare
bmish
force-pushed
the
max-usage-count
branch
from
51f9f7a
to
2065044
Compare
ddzz
reviewed
Sep 15, 2021
| versionObj.packages.length, | ||
| // Bold the usage count if it's the highest, as long as it's not the only usage count present. | ||
| usageCount === highestUsageCount && hasMultipleUsageCounts | ||
| ? chalk.bold(usageCount) |
There was a problem hiding this comment.
Is bold too subtle? Would it make sense to add a color as well?
There was a problem hiding this comment.
It's a bit subtle, but that could be okay because:
- It seems to be the general convention to bold the highest value in a column/list (but I'm not confident about this)
- I don't really want to draw that much attention to it, as the highest dependency version is arguably more important than the highest usage count (in part because we will autofix to the highest dependency version) -- so I was a bit on the fence about this change to begin with
- I'm unaware of any other formatting (colors included) that makes sense
ddzz
approved these changes
Sep 16, 2021
bmish
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bold the usage count of the mismatching dependency version with the highest number of usages as a way of indicating that it's the highest, in case that has some significance in terms of deciding which version should be used.
Bolding the highest value in a list/column is a practice found elsewhere in data visualization.