Fix incorrect autofix for nested dependency

[tamslinn]

I discovered a bug when fixing dependencies with a slash in the name (e.g. @types/jest) - rather than updating them in place, it was adding properties in the format "devDependencies.@types/jest": "^27.0.2",

This PR fixes the issue. I had to upgrade the edit-json-file dependency to enable supplying options to set. Unfortunately typescript complains because @types/edit-json-file has not been updated to cover the new 3rd argument to set

I also updated a test to cover the bug which is being fixed.

[bmish]

Thanks! Can you fix the lint errors?

UPDATE: fixed for you

[bmish]

Can you add a comment to this line explaining what problem this preservePaths option fixes and how it fixes it?

UPDATE: merging now but maybe you can reply to this comment to explain it better.

[tamslinn]

Hi @bmish , sorry I didn't explain it very well. If I ran --fix and the dependency name had a slash in, the resulting package.json had a new entry outside of dependencies, which looked like this:

"dependencies: { ... },
"devDependencies": { ... },
"devDependencies.@types/jest": "^27.0.2",

The fix itself is a setting which is supplied to the set-value library, which is a dependency of edit-json-file, that you are using in your tool. You can see the doc for the preservePaths option here: https://github.com/jonschlinkert/set-value#optionspreservepaths - without this setting it assumes that if the property includes a /, it must be a url, so shouldn't be split even on dots. If that makes sense! It took me a while to track down.

Thanks for accepting the PR.

[bmish]

That's pretty obscure, great find!

[bmish]

Thanks! Released in v1.5.0.

[bmish]

@tamslinn I'm adding the missing TypeScript type for this to @types/edit-json-file so we can clean this up: DefinitelyTyped/DefinitelyTyped#58125

And use this: #313