Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve completeness of example in README #329

Merged
merged 1 commit into from
Jan 21, 2022
Merged

Conversation

bmish
Copy link
Owner

@bmish bmish commented Jan 19, 2022

No description provided.

@bmish bmish added the documentation Improvements or additions to documentation label Jan 19, 2022
"scripts": {
"lint": "npm-run-all --continue-on-error --aggregate-output --parallel lint:*",
"lint:dependency-versions": "check-dependency-version-consistency .",
"lint:dependency-versions:fix": "npm-run-all \"lint:dependency-versions --fix\""
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is npm-run-all needed here?

Copy link
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's one way to call an NPM script from another NPM script. I like it since it doesn't require us to specify npm or yarn as we don't know which dependency manager the reader is using.

@bmish bmish merged commit c06622d into master Jan 21, 2022
@bmish bmish deleted the docs-example-scripts branch January 21, 2022 14:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants