Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use latest version instead of highest version #330

Merged
merged 3 commits into from
Jan 23, 2022
Merged

Use latest version instead of highest version #330

merged 3 commits into from
Jan 23, 2022

Conversation

ddzz
Copy link
Collaborator

@ddzz ddzz commented Jan 21, 2022

No description provided.

@bmish
Copy link
Owner

bmish commented Jan 21, 2022

Should we update this everywhere throughout the codebase?

@ddzz ddzz changed the title README Use latest version instead of highest version Jan 23, 2022
bmish
bmish requested changes Jan 23, 2022
View reviewed changes
Copy link
Owner

@bmish bmish left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like you missed: getHighestVersion

@bmish bmish added the documentation Improvements or additions to documentation label Jan 23, 2022
@ddzz ddzz requested a review from bmish January 23, 2022 15:52
bmish
bmish approved these changes Jan 23, 2022
View reviewed changes
Copy link
Owner

@bmish bmish left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! It would be helpful if the PR description explained why we are making this change.

@bmish bmish merged commit 96f93b4 into bmish:master Jan 23, 2022
@ddzz ddzz deleted the readme branch January 23, 2022 16:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bmish bmish bmish approved these changes

Assignees
No one assigned
Labels
documentation Improvements or additions to documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@ddzz @bmish