Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Autofix to increased latest version range #358

Merged
merged 1 commit into from
Feb 22, 2022
Merged

Conversation

bmish
Copy link
Owner

@bmish bmish commented Feb 21, 2022

Fixing ^1.0.0 and 1.5.0 should fix to ^1.5.0, not 1.5.0. This uses a safe, higher range instead of unnecessarily narrowing the range.

Fixes #353.

TODO:

  • More tests

Later, I would like to cleanup/refactor this implementation some more.

@bmish bmish added the bug Something isn't working label Feb 21, 2022
@bmish bmish force-pushed the increased-latest-version branch 3 times, most recently from fa73500 to 6342f58 Compare February 22, 2022 14:47
@bmish bmish marked this pull request as ready for review February 22, 2022 14:51
@bmish bmish requested a review from ddzz February 22, 2022 14:54
@bmish bmish merged commit 33c92bb into master Feb 22, 2022
@bmish bmish deleted the increased-latest-version branch February 22, 2022 19:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fixing ^1.0.0 and 1.5.0 should fix to ^1.5.0, not 1.5.0
1 participant