Consider nested workspaces #379
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously only the root-level package.json workspaces field was considered; this accumulates packages for consideration even if they are listed in the workspaces list of another package.json file.
bmish
changed the title
|
Thanks for your comments. I've exceeded my time budget for this work. You can finish this one off or discard it and leave it for another day. |
|
@dobesv I'd be happy to finish it for you. I'll push to this PR with some updates in the coming days. |
Thanks. Sorry I couldn't do more, I'm just swamped! |
|
While this could be considered a bug fix, I'll likely consider this a breaking change since it could result in dramatically different results when nested workspaces are present. |
|
Almost done but need to figure out why Windows CI is failing. |
Closed
ddzz
approved these changes
Mar 20, 2022
bmish
approved these changes
Mar 20, 2022
|
Will release this in the coming days as soon as I can finish up #348 to be released with it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously only the root-level package.json workspaces field was considered; this accumulates packages for consideration even if they are listed in the workspaces list of another package.json file.
Fixes #377