Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

pnpm workspace root package should not require name #590

Merged
merged 1 commit into from
May 11, 2023
Merged

pnpm workspace root package should not require name #590

merged 1 commit into from
May 11, 2023

Conversation

bmish
Copy link
Owner

@bmish bmish commented May 11, 2023

@bmish bmish added the bug Something isn't working label May 11, 2023
@bmish bmish changed the title pnpm workspace root should not require name pnpm workspace root package should not require name May 11, 2023
@bmish bmish mentioned this pull request May 11, 2023
Closed
@bmish bmish merged commit 238bd2d into main May 11, 2023
14 checks passed
@bmish bmish deleted the pnpm-workspace-name-missing branch May 11, 2023 20:18
@bmish bmish changed the title pnpm workspace root package should not require name pnpm workspace root package should not require name May 11, 2023
@kachkaev
Copy link
Contributor

kachkaev commented May 11, 2023 •
edited

Terrific! Just tried 3.1.1 without "name" in root package.json – it worked! You are a star 🤩

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Feature Request] Support pnpm
2 participants
@bmish @kachkaev