Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensure config emoji isn't missing in multi-sentence rule doc notice #202

Merged
merged 1 commit into from Nov 1, 2022

Conversation

bmish
Copy link
Owner

@bmish bmish commented Nov 1, 2022

  • Adds config emoji that was sometimes missing from the multi-part rule doc notice
  • Refactors to DRY up the code

Before

💼 This rule warns in the recommended config. This rule is disabled in the typescript config.

After

💼 This rule warns in the ✅ recommended config. This rule is disabled in the ⌨️ typescript config.

@bmish bmish added the bug Something isn't working label Nov 1, 2022
@bmish bmish force-pushed the config-emoji-missing-notice branch from 2d1646d to 74668fa Compare November 1, 2022 13:43
@bmish bmish force-pushed the config-emoji-missing-notice branch from 74668fa to c43362f Compare November 1, 2022 13:44
@bmish bmish force-pushed the config-emoji-missing-notice branch from c43362f to 6145dfd Compare November 1, 2022 13:48
@bmish bmish changed the title Ensure config emoji used in rule doc notice Ensure config emoji isn't missing in multi-sentence rule doc notice Nov 1, 2022
@bmish bmish merged commit b252294 into main Nov 1, 2022
@bmish bmish deleted the config-emoji-missing-notice branch November 1, 2022 13:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants