Enable unicode regexp flag #278
Conversation
| contents.includes(content.replace(/"/gu, '\\"')) || | ||
| contents.includes(content.replace(/'/gu, "\\'")); |
lib/generator.ts
Outdated
| @@ -165,7 +165,7 @@ export async function generate(path: string, options?: GenerateOptions) { | |||
| // Update rule doc for each rule. | |||
| let initializedRuleDoc = false; | |||
| for (const { name, description, schema } of details) { | |||
| const pathToDoc = join(path, pathRuleDoc).replace(/{name}/g, name); | |||
| const pathToDoc = join(path, pathRuleDoc).replace(/\{name\}/gu, name); | |||
There was a problem hiding this comment.
similarly, why does the u flag help here? none of the chars in {name} can be part of a surrogate pair.
There was a problem hiding this comment.
I assume it's just for consistency so require-unicode-regexp can be enabled?
| @@ -42,7 +42,7 @@ export function findSectionHeader( | |||
| str: string | |||
| ): string | undefined { | |||
| // Get all the matching strings. | |||
| const regexp = new RegExp(`## .*${str}.*\n`, 'gi'); | |||
| const regexp = new RegExp(`## .*${str}.*\n`, 'giu'); | |||
There was a problem hiding this comment.
That's a fair concern but realistically I don't think it's an issue and certainly not a blocker. This code is mostly just used for searching for sections like ## Rules, ## Options, ## Config where the flag is unlikely to have an effect. Also I'm still open to breaking changes although I plan to release v1.0.0 very soon.
lib/rule-doc-notices.ts
Outdated
| @@ -227,7 +227,7 @@ function ruleNamesToList( | |||
| : ruleName; | |||
| return `[\`${ruleNameWithoutPluginPrefix}\`](${ | |||
| urlRuleDoc | |||
| ? urlRuleDoc.replace(/{name}/g, ruleName) | |||
| ? urlRuleDoc.replace(/\{name\}/gu, ruleName) | |||
| @@ -29,7 +29,7 @@ import { hasOptions } from './rule-options.js'; | |||
|
|
|||
| // Example: theWeatherIsNice => The Weather Is Nice | |||
| function camelCaseStringToTitle(str: string) { | |||
| const text = str.replace(/([A-Z])/g, ' $1'); | |||
| const text = str.replace(/([A-Z])/gu, ' $1'); | |||
lib/rule-list.ts
Outdated
| @@ -136,7 +136,7 @@ function buildRuleRow( | |||
| ? EMOJI_HAS_SUGGESTIONS | |||
| : '', | |||
| [COLUMN_TYPE.NAME]: `[${rule.name}](${(urlRuleDoc ?? pathRuleDoc).replace( | |||
| /{name}/g, | |||
| /\{name\}/gu, | |||
bmish
added
bug
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| @@ -40,8 +40,8 @@ | |||
| // in case escaping is needed where the content is referenced. | |||
| const hasContent = | |||
| contents.includes(content) || | |||
| contents.includes(content.replace(/"/g, '\\"')) || | |||
| contents.includes(content.replace(/'/g, "\\'")); | |||
| contents.includes(content.replace(/"/gu, '\\"')) || | |||
Check failure
Code scanning / CodeQL
Incomplete string escaping or encoding
| contents.includes(content.replace(/"/g, '\\"')) || | ||
| contents.includes(content.replace(/'/g, "\\'")); | ||
| contents.includes(content.replace(/"/gu, '\\"')) || | ||
| contents.includes(content.replace(/'/gu, "\\'")); |
Check failure
Code scanning / CodeQL
Incomplete string escaping or encoding
|
@bmish awesome - you've already responded with what I would have said 🙂 I'll resolve the conflicts, but what do you want to do about the CodeQL findings? (I'm pretty sure they're not introduced by this change, it's just that its checking those lines for the first time) |
|
@G-Rath I think those CodeQL warnings are the same ones I ignored in the past, now reappearing, so I'll ignore them again. I'll merge after you rebase, thanks! |
I was looking over the codebase to see how easy it might be to implement a feature, and noticed you're not using the
uflag and had some regexps that it helps with ({name}), and figured it'd make a good first contribution :)(I won't be offended if you don't want to land this either)