Ensure TypeScript is checked by CodeQL #281
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This seems harmless but I'm still unclear if it's actually necessary? I have already received CodeQL alerts on my TypeScript code. https://codeql.github.com/docs/codeql-language-guides/codeql-library-for-typescript/
|
|
Yeah I'm not sure what additional checks it enables if any, but according to the folks at GitHub its best to include both and its how we have it covered on their octokit repos 馃し |
bmish
approved these changes
Nov 25, 2022
bmish
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
So apparently
typescriptis different fromjavascriptin CodeQL config, and for best coverage you should include both (personally I think the docs really don't give that impression, but this came from GitHub staff and it doesn't hurt so 馃し)