Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove extra closing quote from error message #286

Merged
merged 1 commit into from
Nov 26, 2022
Merged

Remove extra closing quote from error message #286

merged 1 commit into from
Nov 26, 2022

Conversation

G-Rath
Copy link
Contributor

@G-Rath G-Rath commented Nov 26, 2022

I also removed the dot because it felt like an odd duck to me given the error continues down, i.e.

Error: No rules found with --split-by property "meta.docs.requiresTypeChecking".
    at generateRulesListMarkdownWithSplitBy (file:///home/runner/work/eslint-plugin-jest-extended/eslint-plugin-jest-extended/node_modules/eslint-doc-generator/dist/lib/rule-list.js:[10](https://github.com/jest-community/eslint-plugin-jest-extended/actions/runs/3555029745/jobs/5971494794#step:5:11)9:15)
    at updateRulesList (file:///home/runner/work/eslint-plugin-jest-extended/eslint-plugin-jest-extended/node_modules/eslint-doc-generator/dist/lib/rule-list.js:170:[11](https://github.com/jest-community/eslint-plugin-jest-extended/actions/runs/3555029745/jobs/5971494794#step:5:12))
    at generate (file:///home/runner/work/eslint-plugin-jest-extended/eslint-plugin-jest-extended/node_modules/eslint-doc-generator/dist/lib/generator.js:167:33)
    at async Command.<anonymous> (file:///home/runner/work/eslint-plugin-jest-extended/eslint-plugin-jest-extended/node_modules/eslint-doc-generator/dist/lib/cli.js:109:9)
    at async Command.parseAsync (/home/runner/work/eslint-plugin-jest-extended/eslint-plugin-jest-extended/node_modules/commander/lib/command.js:916:5)
    at async run (file:///home/runner/work/eslint-plugin-jest-extended/eslint-plugin-jest-extended/node_modules/eslint-doc-generator/dist/lib/cli.js:78:5)

@bmish bmish added the bug Something isn't working label Nov 26, 2022
@bmish
Copy link
Owner

bmish commented Nov 26, 2022

Test for this needs to be updated.

@bmish
Copy link
Owner

bmish commented Nov 26, 2022

All our other exceptions end with a period which I think is helpful for knowing where the sentence ends. I would actually like to remove the stack trace from what the user sees, so the error won't be continuing after the message.

Copy link
Owner

@bmish bmish left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@bmish bmish merged commit 8e416ea into bmish:main Nov 26, 2022
@bmish bmish changed the title fix: remove extra closing quote from error message Remove extra closing quote from error message Nov 26, 2022
@G-Rath G-Rath deleted the patch-1 branch November 26, 2022 20:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants