Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use correct path for exported types #298

Merged
merged 1 commit into from
Nov 27, 2022
Merged

Use correct path for exported types #298

merged 1 commit into from
Nov 27, 2022

Conversation

SimenB
Copy link
Contributor

@SimenB SimenB commented Nov 27, 2022 •
edited
Loading

The js file is empty (so no exports), so I think this is correct.

https://www.runpkg.com/?eslint-doc-generator@0.27.0/dist/lib/index.js
https://www.runpkg.com/?eslint-doc-generator@0.27.0/dist/lib/index.d.ts

(at least the current version doesn't work in IntelliJ)

bmish
bmish approved these changes Nov 27, 2022
View reviewed changes
Copy link
Owner

@bmish bmish left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! It was working before based on my testing, but this looks more correct.

@bmish bmish added the bug Something isn't working label Nov 27, 2022
@bmish bmish merged commit 04a0afa into bmish:main Nov 27, 2022
@bmish bmish changed the title fix: correct path to types Use correct path to types Nov 27, 2022
@bmish bmish changed the title Use correct path to types Use correct path for exported types Nov 27, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bmish bmish bmish approved these changes

Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@SimenB @bmish