Hide stack trace when throwing exception #344
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ddzz
approved these changes
Dec 13, 2022
bmish
added a commit
that referenced
this pull request
Dec 14, 2022
* main: Better variable name for rule details (#346) chore(deps-dev): bump @types/node from 18.11.10 to 18.11.13 (#337) chore(deps): bump @typescript-eslint/utils from 5.46.0 to 5.46.1 (#340) chore(deps-dev): bump @typescript-eslint/eslint-plugin from 5.46.0 to 5.46.1 (#341) chore(deps-dev): bump eslint from 8.28.0 to 8.29.0 (#338) Hide stack trace when throwing exception (#344) Move users section in readme (#343) Add table of contents to readme (#342) Add table documenting types of notices and columns (#336) chore(deps-dev): bump @typescript-eslint/parser from 5.45.0 to 5.46.1 chore(deps-dev): bump release-it from 15.5.0 to 15.5.1 Switch to renamed @release-it-plugins/lerna-changelog dev-dependency (#335) chore(deps-dev): bump @typescript-eslint/eslint-plugin Improve comments for emoji definitions (#333) Mention complementary rule `eslint-plugin/require-meta-docs-url` (#332) chore(deps-dev): bump eslint-plugin-square from 23.1.2 to 23.1.3 (#331) chore(deps): bump @typescript-eslint/utils from 5.45.0 to 5.45.1 chore(deps-dev): bump @types/jest from 29.2.3 to 29.2.4
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Caught this bug with https://typescript-eslint.io/rules/no-floating-promises/
The try-catch wasn't working before.
We don't need to show the entire stack trace to end-users, just the error message from the exception.