Improve detection of named options to be mentioned in rule docs #349
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bmish
force-pushed
the
json-schema-traverse
branch
from
3641e94
to
1e6f80a
Compare
ddzz
approved these changes
Dec 15, 2022
bmish
force-pushed
the
json-schema-traverse
branch
2 times, most recently
from
105a22c
to
26e5e4a
Compare
bmish
force-pushed
the
json-schema-traverse
branch
from
26e5e4a
to
5cf17bd
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The custom implementation failed the new test case being added of the "object in array in object" schema.
The new library we're using https://www.npmjs.com/package/json-schema-traverse ensures we fully traverse through any objects/arrays in a JSON schema.