Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support a user-defined function for --url-rule-doc option #369

Merged
merged 1 commit into from Dec 26, 2022
Merged

Support a user-defined function for --url-rule-doc option #369

merged 1 commit into from Dec 26, 2022

Conversation

bmish
Copy link
Owner

@bmish bmish commented Dec 23, 2022 •
edited

Fixes #295.

TODO:

  • Ensure path passed to function is correct
  • README example
  • Test IRL

Alternative designs considered:

  • Named object properties for parameters
  • Pass normal URL as parameter so user can return it or manipulate it instead of returning undefined to fallback

@bmish bmish added the enhancement New feature or request label Dec 23, 2022
@bmish bmish force-pushed the url-rule-doc-function branch 2 times, most recently from ac73b38 to 8863a10 Compare December 26, 2022 20:30
@bmish bmish marked this pull request as ready for review December 26, 2022 20:32
@bmish bmish changed the title Support user-defined function for urlRuleDoc option Support a user-defined function for urlRuleDoc option Dec 26, 2022
@bmish bmish changed the title Support a user-defined function for urlRuleDoc option Support a user-defined function for --url-rule-doc option Dec 26, 2022
@bmish bmish merged commit 4e57a37 into main Dec 26, 2022
@bmish bmish deleted the url-rule-doc-function branch December 26, 2022 20:48
@bmish bmish mentioned this pull request Nov 13, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Option to use full URL to link to rule but only in the top-level README
1 participant
@bmish