Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Validate data being used to create config class #54

Closed
bmitch opened this issue Aug 23, 2017 · 2 comments
Closed

Validate data being used to create config class #54

bmitch opened this issue Aug 23, 2017 · 2 comments

Comments

@bmitch
Copy link
Owner

bmitch commented Aug 23, 2017

Here:

    /**
     * Config constructor.
     * @param array $rawData Raw config data.
     */
    public function __construct(array $rawData = [])
    {
        $this->filesToShow = $rawData['filesToShow'] ?? 10;
        $this->parallelJobs = $rawData['parallelJobs'] ?? 10;
        $this->commitsSince = $rawData['commitsSince'] ?? '10 years ago';
        $this->filesToIgnore = $rawData['filesToIgnore'] ?? [];
    }
@Lucky-Loek
Copy link
Contributor

Will take a look at this today

bmitch added a commit that referenced this issue Sep 24, 2017
Validate data being used to create config class #54
@bmitch
Copy link
Owner Author

bmitch commented Sep 28, 2017

Fixed by #99

@bmitch bmitch closed this as completed Sep 28, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants