Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes #166 - Results Factory to just return the Renderer #169

Merged
merged 1 commit into from
Oct 21, 2017

Conversation

bmitch
Copy link
Owner

@bmitch bmitch commented Oct 21, 2017

No description provided.

@codecov
Copy link

codecov bot commented Oct 21, 2017

Codecov Report

Merging #169 into master will increase coverage by 0.8%.
The diff coverage is 25%.

Impacted file tree graph

@@             Coverage Diff             @@
##             master     #169     +/-   ##
===========================================
+ Coverage     72.37%   73.18%   +0.8%     
- Complexity      104      105      +1     
===========================================
  Files            16       16             
  Lines           362      358      -4     
===========================================
  Hits            262      262             
+ Misses          100       96      -4
Impacted Files Coverage Δ Complexity Δ
src/Renderers/Results/ConsoleResultsRenderer.php 0% <0%> (ø) 2 <1> (+1) ⬆️
src/Commands/ChurnCommand.php 0% <0%> (ø) 6 <0> (ø) ⬇️
src/Factories/ResultsRendererFactory.php 100% <100%> (+25%) 3 <3> (ø) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 89e7890...559923e. Read the comment docs.

@codecov
Copy link

codecov bot commented Oct 21, 2017

Codecov Report

Merging #169 into master will increase coverage by 0.8%.
The diff coverage is 30.76%.

Impacted file tree graph

@@             Coverage Diff             @@
##             master     #169     +/-   ##
===========================================
+ Coverage     72.37%   73.18%   +0.8%     
- Complexity      104      105      +1     
===========================================
  Files            16       16             
  Lines           362      358      -4     
===========================================
  Hits            262      262             
+ Misses          100       96      -4
Impacted Files Coverage Δ Complexity Δ
src/Renderers/Results/ConsoleResultsRenderer.php 0% <0%> (ø) 2 <1> (+1) ⬆️
src/Commands/ChurnCommand.php 0% <0%> (ø) 6 <0> (ø) ⬇️
src/Results/Result.php 96.15% <100%> (ø) 6 <0> (ø) ⬇️
src/Factories/ResultsRendererFactory.php 100% <100%> (+25%) 3 <3> (ø) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 89e7890...04863fd. Read the comment docs.

@bmitch bmitch merged commit e6d1afa into master Oct 21, 2017
@bmitch bmitch deleted the bmitchell-166 branch October 21, 2017 18:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant