Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enhancement: Update phpunit/phpunit #198

Merged
merged 7 commits into from
Feb 6, 2019

Conversation

localheinz
Copy link
Contributor

@localheinz localheinz commented Jan 27, 2019

This PR

  • updates phpunit/phpunit
  • uses an actual version constraint for mockery/mockery
  • fixes risky tests by adding to assertion count from Mockery

πŸ’β€β™‚οΈ For reference, see sebastianbergmann/phpunit@5.7.27...6.5.13.

@codecov
Copy link

codecov bot commented Jan 27, 2019

Codecov Report

Merging #198 into master will decrease coverage by 4.48%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff             @@
##             master    #198      +/-   ##
===========================================
- Coverage     76.08%   71.6%   -4.49%     
  Complexity      109     109              
===========================================
  Files            17      17              
  Lines           322     324       +2     
===========================================
- Hits            245     232      -13     
- Misses           77      92      +15
Impacted Files Coverage Ξ” Complexity Ξ”
src/Renderers/Results/JsonResultsRenderer.php 0% <0%> (-100%) 1% <0%> (ΓΈ)
src/Renderers/Results/CsvResultsRenderer.php 0% <0%> (-100%) 3% <0%> (ΓΈ)
src/Processes/ChurnProcess.php 87.5% <0%> (-12.5%) 7% <0%> (ΓΈ)
src/Results/ResultCollection.php 100% <0%> (ΓΈ) 6% <0%> (ΓΈ) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Ξ” = absolute <relative> (impact), ΓΈ = not affected, ? = missing data
Powered by Codecov. Last update 5cabd86...b916c87. Read the comment docs.

@codecov
Copy link

codecov bot commented Jan 27, 2019

Codecov Report

Merging #198 into master will increase coverage by 0.14%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff              @@
##             master     #198      +/-   ##
============================================
+ Coverage     76.08%   76.23%   +0.14%     
  Complexity      109      109              
============================================
  Files            17       17              
  Lines           322      324       +2     
============================================
+ Hits            245      247       +2     
  Misses           77       77
Impacted Files Coverage Ξ” Complexity Ξ”
src/Results/ResultCollection.php 100% <0%> (ΓΈ) 6% <0%> (ΓΈ) ⬇️
src/Renderers/Results/JsonResultsRenderer.php 100% <0%> (ΓΈ) 1% <0%> (ΓΈ) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Ξ” = absolute <relative> (impact), ΓΈ = not affected, ? = missing data
Powered by Codecov. Last update 32832a3...a1f67c1. Read the comment docs.

@bmitch
Copy link
Owner

bmitch commented Jan 28, 2019

My only concern with this is jumping PhpUnit to a new major version. I'm not sure how widely used 5.* is still.

@localheinz
Copy link
Contributor Author

@bmitch

I wouldn't worry about it, the latest version of phpunit/phpunit is 7.5.2, so we are far behind. Since we are installing phpunit/phpunit with composer, I don't see any issues with what other people use.

@bmitch
Copy link
Owner

bmitch commented Feb 6, 2019

Thank you @localheinz !

@bmitch bmitch merged commit 309c663 into bmitch:master Feb 6, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants