Cleanup dirty record when editor window is closed with close tool in panel header #74
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gsidler
force-pushed
the
bug-event-window-close-handling
branch
from
60aedf7
to
1b8e368
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When an event record is edited in EventWindow and the server rejects to save the record, the store contains a dirty record. If the user then clicks the cancel button, a cleanup is triggered that will remove the dirty event record from the store. If instead the user click the close tool (in panel header), no cleanup is performed and the calendar shows inconsistent information. This PR ensure that the store cleanup is performed when the user abort editing with the close button.
This change is