fscanf and fread ubuntu warnings fixed and attempt to resolve windows warnings and installation issues #9
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Fantastic: thanks for this. Will merge as soon as I can test installation on Ubuntu and OS X. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello,
I tried to make a R wrapper of rword2vec few months ago and had (or still having similar) similar issues. When I tried to install wordVectors in ubuntu 14.04 and R 3.3.0, it gave me these warnings:
I found this solution on stackoverflow for these warnings.
For windows, I suppressed these warnings while compiling (Though it gets rid of all warnings, I don't think it's a fully correct solution) and used "_aligned_malloc" in windows as a substitute to "posix_memalign" in ubuntu. Please give feedback if PR is not as expected :).
Thanks.