Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Migrate away from pypika #99

Closed
aersam opened this issue Jul 3, 2023 · 6 comments
Closed

Migrate away from pypika #99

aersam opened this issue Jul 3, 2023 · 6 comments
Labels
enhancement New feature or request

Comments

@aersam
Copy link
Contributor

aersam commented Jul 3, 2023 •
edited
Loading

use either sqlglot or ibis
@dominikpeter dominikpeter changed the title Migrate away from pypi Migrate away from pypika Jul 3, 2023
@dominikpeter
Copy link
Member

To solve #98

@dominikpeter dominikpeter added the enhancement New feature or request label Jul 3, 2023
@dominikpeter
Copy link
Member

After some research I think we should go for Ibis.

aersam added a commit that referenced this issue Jul 7, 2023
@aersam
wip on ibis, #99
f2c72fd
@aersam
Copy link
Contributor Author

aersam commented Jul 12, 2023

seems to be quite involved... not sure ibis is a good fit anymore. issues so far:

  • reading from existing select using subselect not supported
  • custom functions either not documented or not possible at all. this is a requirement for duckdb's semantic search

@dominikpeter
Copy link
Member

Ibis uses sqlglot in the backend too.
Let’s try this…

@dominikpeter
Copy link
Member

Let's bring the sql query builder to Rust

https://crates.io/crates/sql_query_builder

@aersam
Copy link
Contributor Author

aersam commented Nov 3, 2023

Pypika is coming to live again, so migrating is no prio I guess: kayak/pypika#737

@aersam aersam closed this as completed in 3a83bbf Jun 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@aersam @dominikpeter