New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

'Server' object has no attribute 'close' #31

Closed

jMyles opened this issue Aug 30, 2017 · 1 comment

Contributor

jMyles commented Aug 30, 2017

In the asyncio example, a close method is called on a Server object, but Server has no such method:

https://github.com/bmuller/kademlia/blob/python3.5/examples/example.py#L30

Also, does it perhaps make more sense to call server.close() and loop.close() in a finally clause of the try block at the end there?

The text was updated successfully, but these errors were encountered:

bmuller added a commit that referenced this issue


          Fixes #31 - issue in example

6045e70

Owner

bmuller commented Aug 31, 2017

Thanks @jMyles - fixed now!

bmuller closed this as completed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment