-
Notifications
You must be signed in to change notification settings - Fork 31
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
python 3 and universal wheel support with version bump #2
Conversation
There seems to be a lot of cruft in here in terms of added dependencies (IPython, pudb, coverage, coveralls, importing from |
I cleaned up the Makefile and removed unneeded future imports. The dependencies from 'test_requirements.txt', 'develop_requirements.txt' are only for testing/development and are not part of the final package dependencies. |
There are still future imports in |
Sorry forgot the import in init. Also removed the dev and test requirement you don't want (though I couldn't live without ipython and pudb). |
Is the pull request now to your satisfaction? |
Closing this as python 3 support was added here #3 |
Oddly enough I cannot close my own pull request, @bmuller would you be so kind? |
Yep - thanks for the help @F483! |
No problem now that rpcudp is updated I will focus on getting kademlia on python 3. |
👍 |
Though it is compatible with the previous version, I had to bump the version number so reverse dependencies can require python 3 support.
I added universal wheel support, as I had to make my own wheels for testing with kademlia.
It would be nice if you could publish a new package on pypi soon so I do not have to manage everything with self built wheels.
Greetings
Fabian