Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

python 3 and universal wheel support with version bump #2

Closed
wants to merge 3 commits into from

Conversation

F483
Copy link

@F483 F483 commented Oct 16, 2015

Though it is compatible with the previous version, I had to bump the version number so reverse dependencies can require python 3 support.

I added universal wheel support, as I had to make my own wheels for testing with kademlia.

It would be nice if you could publish a new package on pypi soon so I do not have to manage everything with self built wheels.

Greetings

Fabian

@bmuller
Copy link
Owner

bmuller commented Oct 16, 2015

There seems to be a lot of cruft in here in terms of added dependencies (IPython, pudb, coverage, coveralls, importing from __future__ in every single file whether it's needed or not, etc). Also kademlia shouldn't show up in the Makefile. There's some cleanup necessary before I can take another look.

@F483
Copy link
Author

F483 commented Oct 16, 2015

I cleaned up the Makefile and removed unneeded future imports.

The dependencies from 'test_requirements.txt', 'develop_requirements.txt' are only for testing/development and are not part of the final package dependencies.

@bmuller
Copy link
Owner

bmuller commented Oct 16, 2015

There are still future imports in __init__.py that don't seem necessary and references to IPython in the Makefile. IPython and pubd are not required for development, nor is coverage or coveralls required to run tests (there aren't any). Unnecessary dependencies should not be listed.

@F483
Copy link
Author

F483 commented Oct 16, 2015

Sorry forgot the import in init. Also removed the dev and test requirement you don't want (though I couldn't live without ipython and pudb).

@F483
Copy link
Author

F483 commented Oct 16, 2015

Is the pull request now to your satisfaction?

@bmuller
Copy link
Owner

bmuller commented Nov 5, 2015

Hey @F483 - would #3 be sufficient if merged?

@F483
Copy link
Author

F483 commented Dec 4, 2015

Closing this as python 3 support was added here #3

@F483
Copy link
Author

F483 commented Dec 4, 2015

Oddly enough I cannot close my own pull request, @bmuller would you be so kind?

@bmuller
Copy link
Owner

bmuller commented Dec 4, 2015

Yep - thanks for the help @F483!

@bmuller bmuller closed this Dec 4, 2015
@F483
Copy link
Author

F483 commented Dec 5, 2015

No problem now that rpcudp is updated I will focus on getting kademlia on python 3.

@bmuller
Copy link
Owner

bmuller commented Dec 5, 2015

👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants