Added CargoConfigureLocal task #144
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Any progress on this? |
bmuschko
requested changes
Jan 1, 2018
There was a problem hiding this comment.
Thanks for the pull request. Would you mind also updating the documentation?
build.gradle
Outdated
| @@ -19,7 +19,7 @@ def compatibilityVersion = 1.6 | |||
| sourceCompatibility = compatibilityVersion | |||
| targetCompatibility = compatibilityVersion | |||
| group = 'com.bmuschko' | |||
| version = '2.2.2' | |||
| version = '2.2.3' | |||
There was a problem hiding this comment.
Could you please revert the version number change? I am doing that as part of the release process.
| class CargoConfigureLocal extends LocalCargoContainerTask { | ||
| CargoConfigureLocal() { | ||
| action = 'configure' | ||
| description = 'Configures the container' |
There was a problem hiding this comment.
Should say "Configures the local container". Please also add a dot at the end of the description so it aligns with the other task descriptions.
bmuschko
approved these changes
Jan 2, 2018
|
Thanks again for your pull request. I release a new version with your changes. |
|
You're welcome. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added a task to run the 'configure' task in cargo with a cargoConfigureLocal task.
I'd like the ability to bundle the containers configuration manually onto target via SSH (rather than having to specify usernames and passwords to remotes), so a 'configure' only task is a useful option.
This is also useful as I can add additional generated configuration directories (rather than using configFiles) into the container configuration before starting the container.
Also, I can now manually run and background the start of (e.g.) tomcat on the target using ssh rather than the blocking cargoRunLocal task.
There don't seem to be any tests around creating the cargo*Local tasks, but the implementation is trivial, so I haven't added any either.