Make DockerRemoteApi plugin configuration cache compatible for Gradle 8.1+ #1193
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Configuration cache error is only present in 8+ versions
Test that configuration cache still compatible for Gradle 8.3 when docker sock files are changed between runs.
This will be created for the build and maintain configuration cache compatibility as the values are not resolved during configuration time. Add flag to set for integration test
pbielicki
reviewed
Sep 15, 2023
src/docTest/groovy/com/bmuschko/gradle/docker/RemoteApiPluginDocumentationTest.groovy
Outdated
Show resolved
Hide resolved
pbielicki
reviewed
Sep 15, 2023
src/functTest/groovy/com/bmuschko/gradle/docker/AbstractFunctionalTest.groovy
Outdated
Show resolved
Hide resolved
…onalTest.groovy Co-authored-by: Przemek Bielicki <przemek@gradle.com>
pbielicki
reviewed
Sep 15, 2023
src/functTest/groovy/com/bmuschko/gradle/docker/DockerRemoteApiPluginFunctionalTest.groovy
Show resolved
Hide resolved
pbielicki
reviewed
Sep 15, 2023
src/functTest/groovy/com/bmuschko/gradle/docker/DockerRemoteApiPluginFunctionalTest.groovy
Show resolved
Hide resolved
pbielicki
reviewed
Sep 15, 2023
...functTest/groovy/com/bmuschko/gradle/docker/tasks/image/DockerSaveImageFunctionalTest.groovy
Outdated
Show resolved
Hide resolved
pbielicki
reviewed
Sep 15, 2023
src/main/java/com/bmuschko/gradle/docker/internal/DefaultDockerUrlValueSource.java
Show resolved
Hide resolved
This reverts commit e93d41b.
pbielicki
reviewed
Sep 15, 2023
src/test/groovy/com/bmuschko/gradle/docker/internal/RegistryAuthLocatorTest.groovy
Outdated
Show resolved
Hide resolved
bmuschko
reviewed
Sep 19, 2023
src/functTest/groovy/com/bmuschko/gradle/docker/DockerRemoteApiPluginFunctionalTest.groovy
Show resolved
Hide resolved
bmuschko
reviewed
Sep 19, 2023
src/main/java/com/bmuschko/gradle/docker/internal/DefaultDockerUrlValueSource.java
Show resolved
Hide resolved
Jocce-Nilsson
commented
Sep 20, 2023
| @@ -114,7 +115,7 @@ class DockerRemoteApiPluginFunctionalTest extends AbstractGroovyDslFunctionalTes | |||
| import com.bmuschko.gradle.docker.tasks.image.DockerPullImage | |||
| import com.bmuschko.gradle.docker.tasks.image.DockerRemoveImage | |||
| import com.bmuschko.gradle.docker.tasks.image.Dockerfile | |||
|
|
|||
There was a problem hiding this comment.
auto formatting, is this OK to remove @bmuschko?
There was a problem hiding this comment.
That's fine. Seem like a tab or tabs ended up here.
bmuschko
approved these changes
Sep 20, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Using Gradle 8.1 or above will make Gradle gather information on file access during configuration time. If any of those files change until next time you run Gradle, the configuration cache is invalidated.
This PR delays the file checking for default value of the DockerExtension so that the files are not part of configuration cache input.
closes #1192