ISSUE-651: implemented support for --pid option in DockerCreateContai… #652
Conversation
| @@ -231,6 +235,10 @@ class DockerCreateContainer extends AbstractDockerRemoteApiTask { | |||
| restartPolicy = "${name}:${maximumRetryCount}" | |||
| } | |||
|
|
|||
| void pid(String name) { | |||
| pid = "${name}" | |||
| } | |||
There was a problem hiding this comment.
We generally don't use methods unless there is a good reason. What's the thinking here?
There was a problem hiding this comment.
Let's remove this method. Groovy automatically generates a setter method.
There was a problem hiding this comment.
Oh good to know. Yes I will remove that method then. Should I push it as a 2nd commit or should I commit locally, squash both commits and force push it into the pr/651 branch so that it remains one commit/push on pr/651?
And I don't get why the Travis CI build failed.
It says "Caused by: org.gradle.api.GradleException: The whole test suite should be executed. The test com.bmuschko.gradle.docker.DockerSpringBootApplicationPluginFunctionalTest.Can create image for a Spring Boot application and push it to DockerHub [#plugin.identifier plugin] was skipped. Please check the execution condition!" .. do I have any influence on that when pushing?
There was a problem hiding this comment.
Ignore the Travis CI failure for now as it's a known issue. I would send in another commit with the fix.
…ame in new functional test
src/functTest/groovy/com/bmuschko/gradle/docker/DockerWorkflowFunctionalTest.groovy
Outdated
Show resolved
Hide resolved
moved test from DockerWorkflowFunctionalTest to DockerWorkflowFunctionalTest
|
All tests pass locally. Thanks @marcoebbinghaus ! Did you want a new patch release done for this change? |
|
Thank you for merging @cdancy ! It's okay if it will be in 3.6.2, I don't need a patch release. |
adds support for --pid option in docker create / DockerCreateContainer-Task
closes #651