Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove non pypiscout Emma command line prints #12

Closed
KGergo88 opened this issue Aug 1, 2019 · 2 comments
Closed

Remove non pypiscout Emma command line prints #12

KGergo88 opened this issue Aug 1, 2019 · 2 comments
Assignees
Labels
bug Something isn't working good first issue Good for newcomers low prio This issue is less important than others

Comments

@KGergo88
Copy link
Member

KGergo88 commented Aug 1, 2019

The new pypiscout has the feature to disable log printing based on the log levels.
With this functionality it is possible to completely turn off logging.

It was detected, that even when the logging turned off, there are still messages printed. These are messages that are made with the print() python function.

TODO

  • Review all the print commands whether it is possible to replace them with pypiscout calls.
@KGergo88 KGergo88 added the bug Something isn't working label Aug 1, 2019
@KGergo88 KGergo88 self-assigned this Aug 1, 2019
@holzkohlengrill
Copy link
Collaborator

I think at least in some prompt cases an ordinary print() will be used. That was done by purpose.

However feel free to bring in your findings and we will discuss about that.

@holzkohlengrill holzkohlengrill added good first issue Good for newcomers low prio This issue is less important than others labels Aug 1, 2019
@holzkohlengrill
Copy link
Collaborator

Listing of necessary print()s.

File:Line Rationale
emma_vis_libs/helper.py:65 File listing; (sc().info would decrease readability)
genDoc/_genCallGraphs.py:176 Newline after subprocess call
emma_vis_libs/dataVisualiserObjects.py:47 Print of vis results dataframe
emma_vis_libs/dataVisualiserSections.py:241 Print of vis results dataframe
emma_vis_libs/dataVisualiserSections.py:242 Print of vis results dataframe
emma_vis_libs/dataVisualiserSections.py:243 Print of vis results dataframe
genDoc/genReadmeHtmlFromMd.py:107 Newline after a lot of flexible commands
emma_delta_libs/FilePresenter.py:69 File listing; (sc().info would decrease readability)
emma_delta_libs/FilePresenter.py:78 File listing; (sc().info would decrease readability)
emma_delta_libs/FilePresenter.py:82 File listing; (sc().info would decrease readability)
emma_vis_libs/dataVisualiserCategorisedSections.py:171 Print of vis results dataframe
emma_vis_libs/dataVisualiserCategorisedSections.py:178 Print of vis results dataframe
emma_libs/ghsConfiguration.py:155 Mapfile listing are a "sub-section" of the above scout message to increase readability
emma_libs/ghsConfiguration.py:195 File listing; (sc().info would decrease readability)
emma_libs/ghsConfiguration.py:290 File listing; (sc().info would decrease readability)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working good first issue Good for newcomers low prio This issue is less important than others
Projects
None yet
Development

No branches or pull requests

2 participants