Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SECTIONS_TO_EXCLUDE should be in a configuration file #43

Closed
1 task
holzkohlengrill opened this issue Nov 21, 2019 · 1 comment · Fixed by #84
Closed
1 task

SECTIONS_TO_EXCLUDE should be in a configuration file #43

holzkohlengrill opened this issue Nov 21, 2019 · 1 comment · Fixed by #84
Assignees
@DariaPigasova
Labels
enhancement New feature or request low prio This issue is less important than others SP: 5
Projects
Planning
Milestone
3.3

Comments

@holzkohlengrill
Copy link
Collaborator

holzkohlengrill commented Nov 21, 2019 •
edited by DariaPigasova
Loading

Feature Description

SECTIONS_TO_EXCLUDE (find it here) contains kind of specific data. It would be better placed in the globalConfig file.

Define a default behaviour (= current behaviour with one exception (see below)) and add a weak warning notifying that this setting is not overwritten and the default SECTIONS_TO_EXCLUDE is currently active.

Exception: remove:

".unused_ram",
".mr_rw_NandFlashDataBuffer"

but keep the variable SECTIONS_TO_EXCLUDE.
@holzkohlengrill holzkohlengrill added the enhancement New feature or request label Nov 21, 2019
@holzkohlengrill holzkohlengrill added this to the 3.3 milestone Nov 21, 2019
@holzkohlengrill holzkohlengrill added this to Backlog in Planning May 29, 2020
@holzkohlengrill holzkohlengrill added low prio This issue is less important than others SP: 5 labels May 29, 2020
@holzkohlengrill holzkohlengrill moved this from Backlog to ToDo in Planning Jul 7, 2020
@DariaPigasova DariaPigasova moved this from ToDo to In clarification in Planning Aug 13, 2020
@DariaPigasova
Copy link
Contributor

SECTIONS_TO_EXCLUDE - union of DWARF_SECTIONS and a set that can be defined per config ID.
If section to exclude is not defined in config ID, a weak warning should appear that sections to exclude are not defined in global config and only DWARF_SECTIONS will be excluded. If the flag "analyse_debug" is set, the weak warning should not appear.

@holzkohlengrill holzkohlengrill moved this from In clarification to In progress in Planning Sep 17, 2020
DariaPigasova added a commit that referenced this issue Oct 22, 2020
@DariaPigasova
close #43, changes according to the issue.
6774576
@DariaPigasova DariaPigasova mentioned this issue Oct 22, 2020
Merged
11 tasks
@DariaPigasova DariaPigasova linked a pull request Oct 22, 2020 that will close this issue
close #43, changes according to the issue. #84
Merged
11 tasks
@DariaPigasova DariaPigasova moved this from In progress to Review in progress in Planning Oct 22, 2020
Planning automation moved this from Review in progress to Done Dec 16, 2020
holzkohlengrill added a commit that referenced this issue Dec 16, 2020
@DariaPigasova @holzkohlengrill
put SECTIONS_TO_EXCLUDE in a configuration file
7ed6f82 
* close #43, changes according to the issue.
* Updated wwarning about list type
* Moved sectionsToExclude into str consts
* MAdZ submodule update

Co-authored-by: Marcel Schmalzl <holzkohlengrill@gmail.com>
heliocastro pushed a commit that referenced this issue Mar 7, 2022
@DariaPigasova @holzkohlengrill @heliocastro
put SECTIONS_TO_EXCLUDE in a configuration file
1ecb916 
* close #43, changes according to the issue.
* Updated wwarning about list type
* Moved sectionsToExclude into str consts
* MAdZ submodule update

Co-authored-by: Marcel Schmalzl <holzkohlengrill@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@DariaPigasova DariaPigasova

Labels
enhancement New feature or request low prio This issue is less important than others SP: 5
Projects
Planning
  
Done
Milestone
3.3
Development

Successfully merging a pull request may close this issue.

close #43, changes according to the issue. bmwcarit/Emma
3 participants
@holzkohlengrill @KGergo88 @DariaPigasova