Mergetest Prs #400 #431 #433 #1
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: Ben Greiner <code@bnavigator.de>
Co-authored-by: Ben Greiner <code@bnavigator.de>
Only the outlist specification I am not sure. First, why can subsystem inputs be connected to system outputs? Then, why was the specification and code in __init__ different from that for the inplist? I changed it to match inplist, but left the weird subsystem input configuration. Check comment that starts with "Convert the output list to a matrix".
…hon-control into interconnectedsystems
Co-authored-by: Ben Greiner <code@bnavigator.de>
Co-authored-by: Ben Greiner <code@bnavigator.de>
…hon-control into interconnectedsystems
…re that combines systems with different timebases
Co-authored-by: Ben Greiner <code@bnavigator.de>
…est conversation.
…hon-control into interconnectedsystems
…s default system timebase
…tems, refactored __init__ on both to use it
and clean up codestyle a tiny bit
This was referenced Jul 23, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Do not merge with master
Just to have a
goodoverview of commits and Travis CI jobs.Edit: Okay the linear commit timeline does not really show the merges but just lists the commits in chronological order. Check with your own GUI!