Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[R4R]BEP12: Introduce customized scripts and transfer memo validation #17

Merged
merged 4 commits into from Jun 25, 2019

Conversation

abelliumnt
Copy link
Contributor

@abelliumnt abelliumnt commented Jun 14, 2019

Background

For tokens on binance chain, recently exchanges tender to use a single address for client deposit and require clients to input memo to identify client account information.

This causes a lot of problems for both exchange customer support and clients. Clients may be panic when their tokens are missing and exchange supports have to verify the client deposit transactions manually. This is caused by that many users don’t realize that memo is required or they just forget to do that. What’s worse, sometimes their wallets don’t support transaction memo at all.

So we plan to implement a memo check mechanism on binance chain to filter out all transactions which are intend to deposit tokens to exchanges and have no valid memo.

Motivation

This memo validation can be used for any membership based deposit/charge business model.

This BEP also proposes an important infrastructure for customized scripts. In the future, more amazing features will be built on it.

@abelliumnt abelliumnt changed the title WIP: Implement Memo Validation BEP12: Implement Memo Validation Jun 14, 2019
@abelliumnt abelliumnt changed the title BEP12: Implement Memo Validation [R4R]BEP12: Implement Memo Validation Jun 17, 2019
@abelliumnt abelliumnt changed the title [R4R]BEP12: Implement Memo Validation [WIP]BEP12: Implement Memo Validation Jun 18, 2019
@abelliumnt abelliumnt force-pushed the customized-validate branch 2 times, most recently from daa78bf to 18ea982 Compare June 21, 2019 11:06
@abelliumnt abelliumnt changed the title [WIP]BEP12: Implement Memo Validation [R4R]BEP12: Introduce customized scripts and transfer memo validation Jun 24, 2019
@abelliumnt abelliumnt force-pushed the customized-validate branch 2 times, most recently from 177c495 to 9b0d413 Compare June 25, 2019 06:21
@darren-liu darren-liu merged commit 40d574b into master Jun 25, 2019
Copy link

@jonesk7734 jonesk7734 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

😀

@Rudolfino67
Copy link

@Rudolfino67
Copy link

  • [ ]

@unclezoro unclezoro deleted the customized-validate branch November 28, 2023 04:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants