builder: implement BEP322 builder-api #7
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
irrun
reviewed
Jan 22, 2024
unclezoro
reviewed
Jan 22, 2024
unclezoro
reviewed
Jan 22, 2024
unclezoro
reviewed
Jan 22, 2024
unclezoro
reviewed
Jan 22, 2024
unclezoro
reviewed
Jan 22, 2024
unclezoro
reviewed
Jan 22, 2024
unclezoro
reviewed
Jan 22, 2024
unclezoro
reviewed
Jan 22, 2024
unclezoro
reviewed
Jan 24, 2024
unclezoro
reviewed
Jan 24, 2024
unclezoro
reviewed
Jan 24, 2024
unclezoro
reviewed
Jan 24, 2024
unclezoro
reviewed
Jan 24, 2024
unclezoro
reviewed
Jan 24, 2024
unclezoro
reviewed
Jan 24, 2024
unclezoro
reviewed
Jan 24, 2024
unclezoro
reviewed
Jan 24, 2024
unclezoro
reviewed
Jan 24, 2024
unclezoro
reviewed
Jan 24, 2024
unclezoro
reviewed
Jan 24, 2024
unclezoro
reviewed
Jan 24, 2024
unclezoro
reviewed
Jan 24, 2024
irrun
reviewed
Jan 31, 2024
irrun
reviewed
Jan 31, 2024
irrun
reviewed
Jan 31, 2024
eth/handler.go
Outdated
| @@ -84,10 +83,16 @@ type txPool interface { | |||
| // Add should add the given transactions to the pool. | |||
| Add(txs []*txpool.Transaction, local bool, sync bool) []error | |||
|
|
|||
| // AddBundle should add the given bundle to the pool. | |||
| AddBundle(bundle *types.Bundle) error | |||
|
|
|||
There was a problem hiding this comment.
sorry, the two interface here seems useless
There was a problem hiding this comment.
func (b *EthAPIBackend) SendBundle(ctx context.Context, bundle *types.Bundle) error {
return b.eth.txPool.AddBundle(bundle)
}
There was a problem hiding this comment.
seems useless, the caller does not from interface, I'll remove it
irrun
reviewed
Jan 31, 2024
unclezoro
reviewed
Feb 1, 2024
unclezoro
reviewed
Feb 1, 2024
unclezoro
reviewed
Feb 1, 2024
unclezoro
reviewed
Feb 1, 2024
unclezoro
reviewed
Feb 1, 2024
unclezoro
reviewed
Feb 1, 2024
unclezoro
reviewed
Feb 1, 2024
unclezoro
reviewed
Feb 19, 2024
unclezoro
reviewed
Feb 19, 2024
unclezoro
reviewed
Feb 19, 2024
unclezoro
reviewed
Feb 19, 2024
unclezoro
reviewed
Feb 19, 2024
unclezoro
reviewed
Feb 19, 2024
unclezoro
reviewed
Feb 19, 2024
unclezoro
reviewed
Feb 19, 2024
irrun
reviewed
Mar 11, 2024
internal/ethapi/api_issue.go
Outdated
| return e.Code | ||
| } | ||
|
|
||
| func (s *IssueAPI) ReportIssue(ctx context.Context, args IssueArgs) error { |
There was a problem hiding this comment.
In most case, issue is bid about, tx error or gas error whatever. If mev is not runnig, sendBid would directly return err
irrun
reviewed
Mar 11, 2024
miner/bidder.go
Outdated
| case work := <-b.newBidCh: | ||
| if work.header.Number.Int64() > currentHeight { | ||
| bidNum = 0 | ||
| bidUntil = time.Unix(int64(work.header.Time+b.chain.Config().Parlia.Period-b.config.DelayLeftOver), 0) |
There was a problem hiding this comment.
worker.header.Time has already added period
* consesus: add a interface to set validator at runtime * core/txpool: add bundlepool to maintain bundle txs * core/type: define bundle * internal/ethapi: add sendBundle, bundlePrice, unregis * ethclient: add SendBundle * miner: add fillTransacitonsAndBundles, add Bidder to sendBid to validators * add README.builder.md
unclezoro
approved these changes
Mar 13, 2024
irrun
added a commit
that referenced
this pull request
Apr 1, 2024
* feat: mev-builder * consesus: add a interface to set validator at runtime * core/txpool: add bundlepool to maintain bundle txs * core/type: define bundle * internal/ethapi: add sendBundle, bundlePrice, unregis * ethclient: add SendBundle * miner: add fillTransacitonsAndBundles, add Bidder to sendBid to validators * add README.builder.md --------- Co-authored-by: raina <irunert@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This pr is to implement the BEP322 builder-api.
This project represents a minimal implementation of the protocol and is provided as is. We make no guarantees regarding its functionality or security.
See also: bnb-chain/BEPs#322
Rationale
tell us why we need these changes...
Example
add an example CLI or API response...
Changes
Notable changes: