Skip to content

Commit

Permalink
consensus, misc: remove unnecessary parent gas limit check
Browse files Browse the repository at this point in the history
  • Loading branch information
Mister-EA committed Apr 20, 2023
1 parent 964775c commit c6af1e3
Show file tree
Hide file tree
Showing 2 changed files with 1 addition and 14 deletions.
12 changes: 1 addition & 11 deletions consensus/misc/eip1559.go
Expand Up @@ -28,22 +28,12 @@ import (
// - gas limit check
// - basefee check
func VerifyEip1559Header(config *params.ChainConfig, parent, header *types.Header) error {
// Verify that the gas limit remains within allowed bounds
parentGasLimit := parent.GasLimit
if !config.IsLondon(parent.Number) {
parentGasLimit = parent.GasLimit * params.ElasticityMultiplier
}
if err := VerifyGaslimit(parentGasLimit, header.GasLimit); err != nil {
return err
}

// Verify the header is not malformed
if header.BaseFee == nil {
return fmt.Errorf("header is missing baseFee")
}

if header.BaseFee.Cmp(big.NewInt(params.InitialBaseFee)) != 0 {
return fmt.Errorf("header has a non-zero baseFee of %v", header.BaseFee)
}
// Verify the baseFee is correct based on the parent header.
expectedBaseFee := CalcBaseFee(config, parent)
if header.BaseFee.Cmp(expectedBaseFee) != 0 {
Expand Down
3 changes: 0 additions & 3 deletions consensus/parlia/parlia.go
Expand Up @@ -560,9 +560,6 @@ func (p *Parlia) verifyHeader(chain consensus.ChainHeaderReader, header *types.H
if header.BaseFee != nil {
return fmt.Errorf("invalid baseFee before fork: have %d, expected 'nil'", header.BaseFee)
}
if err := misc.VerifyGaslimit(parent.GasLimit, header.GasLimit); err != nil {
return err
}
} else if err := misc.VerifyEip1559Header(chain.Config(), parent, header); err != nil {
// Verify the header's EIP-1559 attributes.
return err
Expand Down

0 comments on commit c6af1e3

Please sign in to comment.