Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: upstream patches #1076

Merged
merged 31 commits into from Sep 7, 2022
Merged

fix: upstream patches #1076

merged 31 commits into from Sep 7, 2022

Conversation

qinglin89
Copy link
Contributor

Description

Pick some patches from go-ethereum on v1.10.18, mainly including some bug fixes, and would submit some separate prs for left related patches about features/performance.
follow with #1061

Rationale

N/A

Example

N/A

Changes

Notable changes:

  • mainly including some bug fixes
  • core: fix the order of address in queue to drop the oldest txs rather than the newest
  • cmd/utils: double limit on free-disk monitor, monitor for free disk space works pretty well, but the limits are a bit too low
  • cmd/evm: ensure input length is even

ucwong and others added 30 commits September 1, 2022 13:37
Makes the evm json output less verbose: omitting output of `memory` and `returndata` in case they are empty.
…d of error (#24475)

* core: Change Snapshot extension registration failed to Debug

* Update eth/handler.go

Co-authored-by: Martin Holst Swende <martin@swende.se>
"miner" is not set for pending block responses in some cases.

Fixes #24632
This PR fixes a few panics in the chain marker benchmarks. The root
cause for panic is in chain marker the genesis header/block is not
accessible, while it's expected to be obtained in tests. So this PR
avoids touching genesis header at all to avoid panic.
…l (#24663)

This change removes extraneous/unnecessary checks for equality
when comparing 2 accessList values A and B. Given that we validate that
their lengths of A and B are equal, if so and if every element in A is
in B, reflexively every element in B is already in A. If that weren't
the case and an element g existed in A but not in B, that would mean
that there is an extra element and hence a mathematical contradiction.

Fixes #24658
* cmd/evm: ensure input length is even

* cmd/evm: minor nit + lintfix

Co-authored-by: Martin Holst Swende <martin@swende.se>
It was 'int' accidentally, should be DiscReason instead.
Storage proofs were being unmarshalled from the RPC form to the go struct, but were not being included in the final returned struct.
This PR improves the docker build speed for repeated builds where go.mod and go.sum do no change, by placing the downloaded dependencies in a lower layer
This PR doubles the limit on which to trigger automatic shutdown, and also changes the timer to run once every 30s instead of 60s.
Changed `log.Fatal` to `log.Fatalf()` as it has a parameter...
The loop label can be removed because this 'continue' statement
is not in a nested loop.
Co-authored-by: Felix Lange <fjl@twurst.com>
* eth/fetcher: fix test to avoid hanging. Partial fix for #23331

* eth/filters: avoid dangling goroutines

* eth/fetcher: revert closing of proceed
This PR fixes abi checks in the edge case where all arguments are indexed
Fixes three race conditions found through fuzzing by David Theodore
reverse the order of address in queue
@unclezoro
Copy link
Collaborator

LGTM

@brilliant-lx brilliant-lx merged commit 3168a23 into bnb-chain:develop Sep 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
r4r ready for review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet