Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

miner: disable enforceTip when get txs from txpool #1166

Merged
merged 1 commit into from
Nov 7, 2022
Merged

miner: disable enforceTip when get txs from txpool #1166

merged 1 commit into from
Nov 7, 2022

Conversation

qinglin89
Copy link
Contributor

Description

BSC doesn't enable tip mechanism

Rationale

NA

Example

NA

Changes

NA

brilliant-lx
brilliant-lx approved these changes Nov 3, 2022
View reviewed changes
Copy link
Collaborator

@brilliant-lx brilliant-lx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

BSC would not accept EIP1559 transactions, will reject these transaction in TxPool.
Either set it to true or false has the same result, since BSC should not have these kind of transactions.
And set it to false, could save some unnecessary check.

@unclezoro
Copy link
Collaborator

Nice catch

@qinglin89 qinglin89 merged commit 01b78d4 into bnb-chain:develop Nov 7, 2022
This was referenced Nov 29, 2022
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@unclezoro unclezoro unclezoro approved these changes

@brilliant-lx brilliant-lx brilliant-lx approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@qinglin89 @unclezoro @brilliant-lx