worker: some code enhancement on work.go #1174
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
brilliant-lx
requested review from
brilliant-lx,
unclezoro,
j75689,
kyrie-yl and
qinglin89
qinglin89
previously approved these changes
Nov 10, 2022
setunapo
force-pushed
the
worker_no_resubmit_interval_adjust
branch
from
956182d
to
bbb132f
Compare
setunapo
changed the title
setunapo
force-pushed
the
worker_no_resubmit_interval_adjust
branch
2 times, most recently
from
bcc2e22
to
188c5ca
Compare
brilliant-lx
dismissed
qinglin89’s stale review
The base branch was changed.
resubmit intervalAdjust is for PoW only, to remove it to make worker simpler. With PoW, there will be a periodic timer to check if it is the time to stop packing transaction and start calculating the desired hash value, since other miner could succeed in hash compute if it spends too much time packing transactions. It will commit the current fruit to calculate root at a reasonable time. And it will schedule a new work to get a big block if new transaction was received. When there are too many transactions in the TxPool, the interval of the resubmit timer would be increased and vice versa. But it is not needed with PoS related consensus, since the block interval is determined in PoS, and there is already a timer to stop too long packing.
setunapo
force-pushed
the
worker_no_resubmit_interval_adjust
branch
from
188c5ca
to
5eff61c
Compare
brilliant-lx
previously approved these changes
Nov 10, 2022
brilliant-lx
changed the title
bitdaddy89
previously approved these changes
Nov 10, 2022
channel operation is preferred than atomic value check in golang. And it will help for the further refactor on worker.
setunapo
force-pushed
the
worker_no_resubmit_interval_adjust
branch
from
dcc6329
to
4728db7
Compare
unclezoro
approved these changes
Nov 15, 2022
This was referenced Nov 29, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The code of work.go is critical for BSC block generation.
Try to do some code enhancement for it:
1.the resubmit intervalAdjust code was for PoW consensus, can be deleted.
2.change the work interrupt from atomic check to channel communication.
Rationale
With PoW, there will be a periodic timer to check if it is the time to stop packing transaction and start calculating the desired hash value, since other miner could succeed in hash compute if it spends too much time packing transactions.
It will commit the current fruit to calculate root at a reasonable time.
And it will schedule a new work to get a big block if new transaction was received.
When there are too many transactions in the TxPool, the interval of the resubmit timer would be increased and vice versa.
But it is not needed with PoS consensus, since the block interval is determined in PoS and there is already a timer to stop packing for too long.
Example
None
Changes
Remove unused worker code for BSC.