Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

core/forkid: refactor nextForkHash #1177

Merged
merged 1 commit into from
Nov 17, 2022
Merged

core/forkid: refactor nextForkHash #1177

merged 1 commit into from
Nov 17, 2022

Conversation

qinglin89
Copy link
Contributor

@qinglin89 qinglin89 commented Nov 13, 2022 •
edited

Description

Refactor the code for better structure of efficiency.

Rationale

  • We don't need a else statement while the if statement has a return
  • there's no need to use the internal variable next

Example

NA

Changes

Notable changes:
remove the useless code.

@qinglin89 qinglin89 added the r4r ready for review label Nov 13, 2022
@unclezoro
Copy link
Collaborator

Much better PR description is required.

unclezoro
unclezoro requested changes Nov 15, 2022
View reviewed changes
Copy link
Collaborator

@unclezoro unclezoro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Explain the motivation of this PR.

@qinglin89 qinglin89 merged commit dbc70ee into bnb-chain:develop Nov 17, 2022
This was referenced Nov 29, 2022
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@unclezoro unclezoro unclezoro approved these changes

@brilliant-lx brilliant-lx brilliant-lx approved these changes

Assignees
No one assigned
Labels
r4r ready for review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@qinglin89 @unclezoro @brilliant-lx