worker: remove pre-seal empty block #1184
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pre-seal empty block is for PoW to deliver an empty block ASAP to gain the block mine reward. It is useless for PoS consensus and it does not work for BSC either. Delete the code to make worker simpler.
brilliant-lx
requested review from
j75689,
unclezoro,
KeefeL,
kyrie-yl and
qinglin89
qinglin89
approved these changes
Nov 16, 2022
kyrie-yl
approved these changes
Nov 16, 2022
This was referenced Nov 29, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
pre-sealempty block is for PoW to deliver an empty block ASAP to gain the block mine reward.It is useless for PoS consensus and it does not work for BSC either.
Delete the code to make worker simpler.
Rationale
NA
Example
NA
Changes
NA