Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: disable CGO_ENABLED when building binary #1256

Merged
merged 1 commit into from
Feb 2, 2023

Conversation

j75689
Copy link
Contributor

@j75689 j75689 commented Dec 28, 2022

Description

ci: disable CGO_ENABLED when building binary

Rationale

The current release binary will depend on GLIBC, which may make some Users not easy to use, so disable CGO_ENABLED in the official release version to remove the dependency on C lib.

image

Example

https://github.com/j75689/bsc/releases/tag/v1.1.19-rc3

Changes

Notable changes:

  • ci(release)

@j75689 j75689 added the r4r ready for review label Dec 28, 2022
@brilliant-lx brilliant-lx merged commit 176ab95 into bnb-chain:develop Feb 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
r4r ready for review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants