txpool/legacypool: deprecate already known error #2190
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MatusKysel
approved these changes
Jan 29, 2024
weiihann
added a commit
to weiihann/bsc
that referenced
this pull request
Feb 5, 2024
This was referenced Feb 18, 2024
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR deprecates the usage of
ErrAlreadyKnownin thelegacypoolpackage. Existing dependencies on this error type should usetxpool.ErrAlreadyKnowninstead.Rationale
Originally, upon triggering
legacypool.ErrAlreadyKnown, this error will be propagated back to the initial caller functions.For example, in this code, the expected behavior is that the metrics will be bumped if
txpool.ErrAlreadyKnownfunction is used. However,legacypool.ErrAlreadyKnownandtxpool.ErrAlreadyKnownare 2 different error types with the same error messages. Hence, the case of checking if the error is oftxpool.ErrAlreadyKnownwill not be triggered so it will go to the default case instead.