Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: support MEV #2224

Merged
merged 4 commits into from
Mar 8, 2024
Merged

feat: support MEV #2224

merged 4 commits into from
Mar 8, 2024

Conversation

irrun
Copy link
Contributor

@irrun irrun commented Feb 19, 2024

Description

  • core/types: define Bid and related error message
  • internal/eth_api: add MevAPI to receive bids from builder
  • eth/api_admin: add API to support start and stop mev dynamically
  • miner: add bidSimulator to maintain bid simulation and fetch best bid from
  • consensus: add func to query the next inturn validator
  • ethclient: add clients for MevAPI

Rationale

bnb-chain/BEPs#322 (comment)

Example

add an example CLI or API response...

Changes

Notable changes:

  • add each change in a bullet point here
  • ...

unclezoro
unclezoro reviewed Feb 21, 2024
View reviewed changes
core/types/bid.go Outdated Show resolved Hide resolved
unclezoro
unclezoro reviewed Feb 21, 2024
View reviewed changes
core/types/bid.go Outdated Show resolved Hide resolved
unclezoro
unclezoro reviewed Feb 21, 2024
View reviewed changes
core/types/bid.go Outdated Show resolved Hide resolved
unclezoro
unclezoro reviewed Feb 21, 2024
View reviewed changes
core/types/bid.go Outdated Show resolved Hide resolved
unclezoro
unclezoro reviewed Feb 21, 2024
View reviewed changes
core/types/bid.go Outdated Show resolved Hide resolved
unclezoro
unclezoro reviewed Feb 21, 2024
View reviewed changes
core/types/bid.go Outdated Show resolved Hide resolved
unclezoro
unclezoro reviewed Feb 21, 2024
View reviewed changes
core/types/bid_error.go Outdated Show resolved Hide resolved
unclezoro
unclezoro reviewed Feb 21, 2024
View reviewed changes
eth/api_admin.go Outdated Show resolved Hide resolved
unclezoro
unclezoro reviewed Feb 21, 2024
View reviewed changes
miner/bid_simulator.go Outdated Show resolved Hide resolved
unclezoro
unclezoro reviewed Feb 21, 2024
View reviewed changes
miner/bid_simulator.go Outdated Show resolved Hide resolved
unclezoro
unclezoro reviewed Feb 21, 2024
View reviewed changes
miner/bid_simulator.go Outdated Show resolved Hide resolved
unclezoro
unclezoro reviewed Feb 21, 2024
View reviewed changes
miner/bid_simulator.go Outdated Show resolved Hide resolved
unclezoro
unclezoro reviewed Feb 21, 2024
View reviewed changes
miner/bid_simulator.go Outdated Show resolved Hide resolved
unclezoro
unclezoro reviewed Feb 21, 2024
View reviewed changes
miner/bid_simulator.go Outdated Show resolved Hide resolved
unclezoro
unclezoro reviewed Feb 21, 2024
View reviewed changes
miner/bid_simulator.go Outdated Show resolved Hide resolved
unclezoro
unclezoro reviewed Feb 21, 2024
View reviewed changes
miner/miner.go Outdated Show resolved Hide resolved
unclezoro
unclezoro reviewed Feb 21, 2024
View reviewed changes
miner/miner_mev.go Outdated Show resolved Hide resolved
unclezoro
unclezoro reviewed Feb 21, 2024
View reviewed changes
miner/miner_mev.go Outdated Show resolved Hide resolved
unclezoro
unclezoro reviewed Feb 21, 2024
View reviewed changes
miner/miner_mev.go Outdated Show resolved Hide resolved
unclezoro
unclezoro reviewed Feb 21, 2024
View reviewed changes
miner/miner_mev.go Outdated Show resolved Hide resolved
unclezoro
unclezoro reviewed Feb 21, 2024
View reviewed changes
miner/miner_mev.go Outdated Show resolved Hide resolved
unclezoro
unclezoro reviewed Feb 21, 2024
View reviewed changes
miner/miner_mev.go Outdated Show resolved Hide resolved
unclezoro
unclezoro reviewed Feb 21, 2024
View reviewed changes
miner/miner_mev.go Outdated Show resolved Hide resolved
unclezoro
unclezoro reviewed Feb 21, 2024
View reviewed changes
miner/miner_mev.go Outdated Show resolved Hide resolved
unclezoro
unclezoro reviewed Feb 21, 2024
View reviewed changes
miner/worker.go Outdated Show resolved Hide resolved
@irrun irrun requested a review from unclezoro February 22, 2024 13:17
unclezoro
unclezoro reviewed Feb 23, 2024
View reviewed changes
core/types/bid.go Outdated Show resolved Hide resolved
@irrun irrun requested a review from unclezoro February 23, 2024 03:57
@irrun
feat: support MEV
0fd52bb 
* core/types: define Bid and related error message
* internal/eth_api: add MevAPI to receive bids from builder
* eth/api_admin: add API to support start and stop mev dynamically
* miner: add bidSimulator to maintain bid simulation and fetch best bid from
* consensus: add func to query the next inturn validator
buddh0
buddh0 reviewed Mar 7, 2024
View reviewed changes
miner/bid_simulator.go Outdated Show resolved Hide resolved
@irrun irrun force-pushed the raina/BEP-322 branch 2 times, most recently from 7423fb8 to ec87f9c Compare March 7, 2024 12:35
@irrun irrun requested review from buddh0 and j75689 March 8, 2024 01:53
buddh0
buddh0 previously approved these changes Mar 8, 2024
View reviewed changes
@unclezoro unclezoro merged commit 89c4ab2 into bnb-chain:develop Mar 8, 2024
7 checks passed
This was referenced Mar 12, 2024
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@unclezoro unclezoro unclezoro approved these changes

@NathanBSC NathanBSC NathanBSC approved these changes

@buddh0 buddh0 buddh0 left review comments

@j75689 j75689 Awaiting requested review from j75689

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@irrun @unclezoro @buddh0 @j75689 @NathanBSC