fix: add FeynmanFix upgrade for a testnet issue #2288
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pythonberg1997
changed the base branch from
release_v1.3.10_fix
to
v1.3.10_base
unclezoro
reviewed
Mar 14, 2024
unclezoro
reviewed
Mar 14, 2024
unclezoro
reviewed
Mar 14, 2024
unclezoro
reviewed
Mar 14, 2024
|
not support flag? maybe align with flag OverrideFeynman is better |
unclezoro
reviewed
Mar 18, 2024
params/config.go
Outdated
| ShanghaiTime *uint64 `json:"shanghaiTime,omitempty"` // Shanghai switch time (nil = no fork, 0 = already on shanghai) | ||
| KeplerTime *uint64 `json:"keplerTime,omitempty"` // Kepler switch time (nil = no fork, 0 = already activated) | ||
| FeynmanTime *uint64 `json:"feynmanTime,omitempty"` // Feynman switch time (nil = no fork, 0 = already activated) | ||
| FeynmanFixTime *uint64 `json:"feynmanFixTime,omitempty"` // Feynman switch time (nil = no fork, 0 = already activated) |
There was a problem hiding this comment.
Fix comment Feynman switch time
unclezoro
approved these changes
Mar 18, 2024
forcodedancing
approved these changes
Mar 18, 2024
weiihann
pushed a commit
to weiihann/bsc
that referenced
this pull request
Mar 18, 2024
zzzckck
pushed a commit
that referenced
this pull request
Mar 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This pr is to add FeynmanFix upgrade.
Rationale
There's one issue within the
StakeHubsystem contract. This pr is to add a new hardfork to upgrade the contract code.For more info about the contract issue, please refer to bnb-chain/bsc-genesis-contract#523
Example
add an example CLI or API response...
Changes
Notable changes: