Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

4844: bugfix and improve #2337

Merged
merged 15 commits into from
Mar 28, 2024
Merged

4844: bugfix and improve #2337

merged 15 commits into from
Mar 28, 2024

Conversation

buddh0
Copy link
Collaborator

@buddh0 buddh0 commented Mar 26, 2024 •
edited

Description

bugfix

  1. DeleteBlobSidecars when setHeadBeyondRoot
  2. fix blob number check when downloading block body
  3. modify resetItems
    a. add lock
    b. remove all data files and prevent from overflow
    c. set metadata
    d. sync index file before reopen
  4. only newSnapshot for genesis block
  5. ResetEmptyBlobAncientTable in proper order
  6. accept nil sidecars in block after cancun, but reset it to empty slices, this also solve the stuck issue in QA env
  7. fix EmptyBody

improvement

  1. rename ReadRawBlobSidecars to ReadBlobSidecars
  2. delete dead code in freezeRangeWithBlobs
  3. narrow the semantics of resetItems and ResetTable

Rationale

tell us why we need these changes...

Example

add an example CLI or API response...

Changes

Notable changes:

  • add each change in a bullet point here
  • ...

@buddh0 buddh0 changed the title cancun: bugfix cancun: bugfix and improve Mar 26, 2024
@buddh0 buddh0 marked this pull request as draft March 26, 2024 07:30
buddh0
buddh0 commented Mar 26, 2024
View reviewed changes
core/rawdb/freezer_table.go Outdated Show resolved Hide resolved
buddh0
buddh0 commented Mar 26, 2024
View reviewed changes
core/rawdb/freezer_table.go Outdated Show resolved Hide resolved
@buddh0 buddh0 changed the title cancun: bugfix and improve 4844: bugfix and improve Mar 26, 2024
@buddh0 buddh0 force-pushed the cancun_fix branch 2 times, most recently from f065d9b to 5564fc1 Compare March 26, 2024 07:52
@buddh0 buddh0 marked this pull request as ready for review March 26, 2024 07:52
galaio
galaio previously approved these changes Mar 26, 2024
View reviewed changes
@buddh0 buddh0 force-pushed the cancun_fix branch 2 times, most recently from 3406c2c to ace6df5 Compare March 27, 2024 01:18
@buddh0
Copy link
Collaborator Author

buddh0 commented Mar 27, 2024

force push to solve conflicts with develop

@buddh0 buddh0 requested a review from unclezoro as a code owner March 27, 2024 09:43
@NathanBSC
Copy link
Contributor

LGTM

zzzckck
zzzckck previously approved these changes Mar 28, 2024
View reviewed changes
brilliant-lx
brilliant-lx previously approved these changes Mar 28, 2024
View reviewed changes
@buddh0
Copy link
Collaborator Author

buddh0 commented Mar 28, 2024

rebased

@zzzckck zzzckck dismissed stale reviews from brilliant-lx, galaio, and themself via fda2290 March 28, 2024 08:31
@zzzckck zzzckck merged commit 7c89c65 into develop Mar 28, 2024
6 of 7 checks passed
This was referenced Apr 2, 2024
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@unclezoro unclezoro unclezoro approved these changes

@setunapo setunapo setunapo approved these changes

@NathanBSC NathanBSC NathanBSC approved these changes

@0xbundler 0xbundler 0xbundler approved these changes

@Pjrich1313 Pjrich1313 Pjrich1313 approved these changes

@zzzckck zzzckck zzzckck approved these changes

@galaio galaio galaio left review comments

@brilliant-lx brilliant-lx brilliant-lx left review comments

@emailtovamos emailtovamos Awaiting requested review from emailtovamos

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
9 participants
@buddh0 @NathanBSC @unclezoro @galaio @brilliant-lx @setunapo @0xbundler @Pjrich1313 @zzzckck