Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: no import blocks before or equal to the finalized height #2398

Merged
merged 1 commit into from
Apr 17, 2024
Merged

fix: no import blocks before or equal to the finalized height #2398

merged 1 commit into from
Apr 17, 2024

Conversation

buddh0
Copy link
Collaborator

@buddh0 buddh0 commented Apr 17, 2024 •
edited

Description

fix: no import blocks before or equal to the finalized height

Rationale

Block imported below final block reported
this PR is to solve it

Example

add an example CLI or API response...

Changes

Notable changes:

  • add each change in a bullet point here
  • ...

@buddh0 buddh0 marked this pull request as ready for review April 17, 2024 03:37
@buddh0 buddh0 requested a review from zzzckck as a code owner April 17, 2024 03:37
@buddh0 buddh0 requested a review from galaio April 17, 2024 03:39
@zzzckck zzzckck merged commit cbcd26c into bnb-chain:develop Apr 17, 2024
7 checks passed
This was referenced Apr 26, 2024
Merged
Merged
@buddh0 buddh0 deleted the no_import_blocks_before_finalized_height branch May 7, 2024 11:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@galaio galaio galaio approved these changes

@zzzckck zzzckck zzzckck approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@buddh0 @galaio @zzzckck