[R4R] performance improvement in many aspects #257
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
unclezoro
force-pushed
the
improve_8
branch
13 times, most recently
from
62904a0
to
5bdb7b4
Compare
unclezoro
force-pushed
the
improve_8
branch
17 times, most recently
from
0a1cc10
to
e750b5d
Compare
yutianwu
reviewed
Jul 14, 2021
|
|
||
| go p.peer.RequestHeadersByNumber(from, count, 0, false) |
There was a problem hiding this comment.
It is used when clients doing fast sync and snap sync. Not related to performance
yutianwu
reviewed
Jul 14, 2021
p2p/rlpx/rlpx.go
Outdated
| "github.com/ethereum/go-ethereum/crypto" | ||
| "github.com/ethereum/go-ethereum/crypto/ecies" | ||
| "github.com/ethereum/go-ethereum/rlp" | ||
| "github.com/golang/snappy" | ||
| "golang.org/x/crypto/sha3" | ||
| "github.com/oxtoacart/bpool" |
yutianwu
reviewed
Jul 15, 2021
core/blockchain.go
Outdated
| } | ||
| if len(accountsSlice) >= preLoadLimit { | ||
| objsChan := make(chan []*state.StateObject, runtime.NumCPU()) | ||
| for i := 0; i < runtime.NumCPU(); i++ { |
There was a problem hiding this comment.
should we make sure that len(accountsSlice) > runtime.NumCPU()
There was a problem hiding this comment.
Add one more condition: len(accountsSlice) > runtime.NumCPU()
yutianwu
reviewed
Jul 15, 2021
zfesd
approved these changes
Jul 19, 2021
ifstatic
approved these changes
Jul 26, 2021
|
Can we get this PR merged? |
yutianwu
approved these changes
Jul 29, 2021
j75689
approved these changes
Jul 29, 2021
3 tasks
j75689
added a commit
to j75689/bsc
that referenced
this pull request
Mar 24, 2022
owen-reorg
pushed a commit
to bnb-chain/op-geth
that referenced
this pull request
May 31, 2023
Description: This PR refers to the code optimization done by `BSC`, which mainly includes the following parts: 1. Do BlockBody verification concurrently. 2. Do the calculation of intermediate root concurrently. 3. Commit the MPTs concurrently. 4. Preload accounts before processing blocks. 5. Make the snapshot layers configurable. 6. Reuse some objects to reduce GC. 7. Add shared_pool for `stateDB` to improve cache usage. References: - bnb-chain/bsc#257 - bnb-chain/bsc#792 --------- Co-authored-by: j75689 <j75689@gmail.com> Co-authored-by: realowen <131384228+realowen@users.noreply.github.com>
owen-reorg
pushed a commit
to bnb-chain/op-geth
that referenced
this pull request
May 31, 2023
Description This PR refers to the code optimization done by `BSC`, which mainly includes the following parts: 1. Do BlockBody verification concurrently. 2. Do the calculation of intermediate root concurrently. 3. Commit the MPTs concurrently. 4. Preload accounts before processing blocks. 5. Make the snapshot layers configurable. 6. Reuse some objects to reduce GC. 7. Add shared_pool for `stateDB` to improve cache usage. References - bnb-chain/bsc#257 - bnb-chain/bsc#792 --------- Co-authored-by: j75689 <j75689@gmail.com> Co-authored-by: realowen <131384228+realowen@users.noreply.github.com>
owen-reorg
pushed a commit
to bnb-chain/op-geth
that referenced
this pull request
May 31, 2023
Description This PR refers to the code optimization done by `BSC`, which mainly includes the following parts: 1. Do BlockBody verification concurrently. 2. Do the calculation of intermediate root concurrently. 3. Commit the MPTs concurrently. 4. Preload accounts before processing blocks. 5. Make the snapshot layers configurable. 6. Reuse some objects to reduce GC. 7. Add shared_pool for `stateDB` to improve cache usage. References - bnb-chain/bsc#257 - bnb-chain/bsc#792 --------- Co-authored-by: j75689 <j75689@gmail.com>
brilliant-lx
added a commit
to brilliant-lx/bsc
that referenced
this pull request
Oct 27, 2023
accountTrieCache and storageTrieCache were introduced in this PR: bnb-chain#257, which is to improve performance. Actually the performance gain is quite limitted, as there is already dirty and clean cache for trie node. And after big merge, these 2 cache can not be used when PBSS is enabled. So remove these code to simplify the logic.
brilliant-lx
added a commit
that referenced
this pull request
Oct 30, 2023
accountTrieCache and storageTrieCache were introduced in this PR: #257, which is to improve performance. Actually the performance gain is quite limited, as there is already dirty and clean cache for trie node. And after big merge, these 2 cache can not be used when PBSS is enabled. So remove these code to simplify the logic.
whw188
pushed a commit
to tylerteea/mev-bsc
that referenced
this pull request
Dec 6, 2023
accountTrieCache and storageTrieCache were introduced in this PR: bnb-chain#257, which is to improve performance. Actually the performance gain is quite limited, as there is already dirty and clean cache for trie node. And after big merge, these 2 cache can not be used when PBSS is enabled. So remove these code to simplify the logic.
sunny2022da
added a commit
to sunny2022da/op-geth
that referenced
this pull request
Apr 10, 2024
This is part of the optimizations from BSC, microbench show the change could introduce speed up of simple erc20 transfer scenario. The original PR of BSC: bnb-chain/bsc#257
sunny2022da
added a commit
to sunny2022da/op-geth
that referenced
this pull request
Apr 10, 2024
This is part of the optimizations from BSC, microbench show the change could introduce ~20% speed up of simple erc20 transfer scenario. The original PR of BSC: bnb-chain/bsc#257
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR tries to improve the performance of BSC.
Rationale
Part of Block Processing can be parallel, and the layer of the snapshot is too deeper for the current implementation. This PR focus on:
Example
The testing result on an 8 core 2.5G Hz Linux VM:
Changes
New command flags:
--triesInMemoryPreflight checks
make build)make test)Already reviewed by
...
Related issues
... reference related issue #'s here ...