[R4R] add extension in eth protocol handshake to disable tx broadcast #412
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yutianwu
force-pushed
the
p2p_improve
branch
3 times, most recently
from
4a9ede4
to
8705dbc
Compare
yutianwu
changed the title
yutianwu
changed the title
unclezoro
reviewed
Sep 18, 2021
yutianwu
force-pushed
the
p2p_improve
branch
from
d5c4e29
to
22c6b28
Compare
unclezoro
reviewed
Sep 18, 2021
yutianwu
force-pushed
the
p2p_improve
branch
from
22c6b28
to
b05ac6e
Compare
yutianwu
changed the title
unclezoro
approved these changes
Sep 26, 2021
yutianwu
force-pushed
the
p2p_improve
branch
from
b05ac6e
to
19ae27f
Compare
kyrie-yl
reviewed
Oct 12, 2021
| @@ -44,7 +46,6 @@ import ( | |||
| "github.com/ethereum/go-ethereum/params" | |||
| "github.com/ethereum/go-ethereum/rlp" | |||
| "github.com/ethereum/go-ethereum/trie" | |||
| lru "github.com/hashicorp/golang-lru" | |||
There was a problem hiding this comment.
just fix the imports
| defer timeout.Stop() | ||
| for i := 0; i < 2; i++ { | ||
| select { | ||
| case err := <-errc: |
There was a problem hiding this comment.
I think you need make sure errc is clear before read from it.
There was a problem hiding this comment.
if the errc is not empty, the upper code should complain
kyrie-yl
approved these changes
Oct 12, 2021
j75689
reviewed
Oct 12, 2021
j75689
approved these changes
Oct 13, 2021
This was referenced Oct 19, 2021
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Add a new protocol version
67in eth protocol, and add another round of handshake if peer's protocol version is larger than67. In the new handshake message, we added an extennsion to control some new features. Currently, we only add a switch to turn off tx broadcast to the connected peer. but we can add more options in the future without adding new params.Rationale
Some nodes may do not need to receive txs broadcasted from other peers. When the network is congested, these nodes will take a lot of time to handle these txs and be unstable for queries. So we add a switch to turn off the tx broadcast for some specific nodes to make the network more stable.
Example
Changes
Notable changes:
67Preflight checks
make build)make test)Already reviewed by
...
Related issues
... reference related issue #'s here ...