Export get diff accounts in block api #431
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
unclezoro
reviewed
Oct 8, 2021
core/blockchain.go
Outdated
| accounts = append(accounts, diffAccounts.Account) | ||
| } | ||
|
|
||
| if header.TxHash != types.EmptyRootHash && (accounts == nil || len(accounts) == 0) { |
There was a problem hiding this comment.
accounts == nil || len(accounts) ==0 ==> len(accounts)==0
unclezoro
reviewed
Oct 8, 2021
ethclient/ethclient.go
Outdated
| } | ||
|
|
||
| // GetDiffAccountsInBlock returns detailed changes of some interested accounts in a specific block number. | ||
| func (ec *Client) GetDiffAccountsInBlock(ctx context.Context, number *big.Int, accounts []common.Address) (*types.DiffAccountsInBlock, error) { |
There was a problem hiding this comment.
It is confusing between GetDiffAccounts and GetDiffAccountsInBlock.
I will suggest change GetDiffAccountsInBlock ==> GetDiffAccountsWithScope
unclezoro
reviewed
Oct 8, 2021
internal/ethapi/api.go
Outdated
| @@ -25,6 +25,8 @@ import ( | |||
| "strings" | |||
| "time" | |||
|
|
|||
| "github.com/ethereum/go-ethereum/consensus" | |||
unclezoro
reviewed
Oct 8, 2021
internal/ethapi/api.go
Outdated
| } | ||
|
|
||
| // GetDiffAccountsInBlock returns detailed changes of some interested accounts in a specific block number. | ||
| func (s *PublicBlockChainAPI) GetDiffAccountsInBlock(ctx context.Context, blockNr rpc.BlockNumber, accounts []common.Address) (*types.DiffAccountsInBlock, error) { |
There was a problem hiding this comment.
change the nameGetDiffAccountsInBlock
unclezoro
reviewed
Oct 8, 2021
|
|
||
| if !skip { | ||
| // Compute account balance diff. | ||
| for _, account := range accounts { |
There was a problem hiding this comment.
If the account balance diff is zero, please do not record it in the map.
Signed-off-by: Keefe-Liu <bianze.kernel@gmail.com>
yutianwu
reviewed
Oct 8, 2021
ethclient/ethclient_test.go
Outdated
| @@ -25,6 +25,9 @@ import ( | |||
| "testing" | |||
| "time" | |||
|
|
|||
| "github.com/ethereum/go-ethereum/core/vm" | |||
| "github.com/ethereum/go-ethereum/ethdb/memorydb" | |||
|
|
|||
unclezoro
reviewed
Oct 8, 2021
| // Compute account balance diff. | ||
| for _, account := range accounts { | ||
| diffTx.Accounts[account] = new(big.Int).Sub(statedb.GetBalance(account), diffTx.Accounts[account]) | ||
| if diffTx.Accounts[account].Cmp(big.NewInt(0)) == 0 { |
There was a problem hiding this comment.
why not if equal to 0, then not record?
There was a problem hiding this comment.
sorry, I don't get your point, do you mean convert bigInt into int then compare with 0 directly?
Signed-off-by: Keefe-Liu <bianze.kernel@gmail.com>
unclezoro
approved these changes
Oct 8, 2021
This was referenced Oct 19, 2021
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Export GetDiffAccounts and GetDiffAccountsWithScope, GetDiffAccounts can get all diff accounts in a block, GetDiffAccountsWithScope can pass the interested accounts and return their diff value in a block.
Rationale
To get diff accounts in a block easily.
Example
Changes
Preflight checks
Already reviewed by
...
Related issues
... reference related issue #'s here ...